admin/gotgt
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix part of golint

Browse Source
This commit is contained in:
Lei Xue
2022-12-11 09:59:06 +08:00
parent e6ab29e842
commit 1c9f8d3e06
15 changed files with 21 additions and 1174 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/scsi/error.go
View File

@@ -117,7 +117,7 @@ var (
ASC_MEDIUM_SRC_EMPTY SCSISubError = 0x3b0e
ASC_POSITION_PAST_BOM SCSISubError = 0x3b0c
ASC_MEDIUM_REMOVAL_PREVENTED SCSISubError = 0x5302
ASC_INSUFFICENT_REGISTRATION_RESOURCES SCSISubError = 0x5504
ASC_INSUFFICIENT_REGISTRATION_RESOURCES SCSISubError = 0x5504
ASC_BAD_MICROCODE_DETECTED SCSISubError = 0x8283
// Key 6: Unit Attention

10
pkg/scsi/scsi.go
View File

@@ -28,6 +28,7 @@ import (
log "github.com/sirupsen/logrus"
)
// SCSITargetService SCSI target service
type SCSITargetService struct {
mutex sync.RWMutex
Targets []*api.SCSITarget
@@ -36,6 +37,7 @@ type SCSITargetService struct {
var _instance *SCSITargetService
var service sync.Once
// NewSCSITargetService create a new SCSITargetService
func NewSCSITargetService() *SCSITargetService {
service.Do(func() {
_instance = &SCSITargetService{Targets: []*api.SCSITarget{}}
@@ -43,6 +45,7 @@ func NewSCSITargetService() *SCSITargetService {
return _instance
}
// GetTargetList get SCSI target list
func (s *SCSITargetService) GetTargetList() ([]api.SCSITarget, error) {
result := []api.SCSITarget{}
s.mutex.RLock()
@@ -53,6 +56,7 @@ func (s *SCSITargetService) GetTargetList() ([]api.SCSITarget, error) {
return result, nil
}
// Resize resize
func (s *SCSITargetService) Resize(size uint64) error {
s.mutex.Lock()
//TODO for multiple LUNs
@@ -67,6 +71,7 @@ func (s *SCSITargetService) Resize(size uint64) error {
return nil
}
// AddCommandQueue add command queue
func (s *SCSITargetService) AddCommandQueue(tid int, scmd *api.SCSICommand) error {
var (
target *api.SCSITarget
@@ -115,22 +120,26 @@ func (s *SCSITargetService) AddCommandQueue(tid int, scmd *api.SCSICommand) erro
return nil
}
// SCSIServiceAction SCSI service action
type SCSIServiceAction struct {
ServiceAction uint8
CommandPerformFunc api.CommandFunc
}
// SCSIDeviceOperation SCSI device operation
type SCSIDeviceOperation struct {
CommandPerformFunc api.CommandFunc
ServiceAction []*SCSIServiceAction
PRConflictBits uint8
}
// BaseSCSIDeviceProtocol base SCSI device protocol
type BaseSCSIDeviceProtocol struct {
DeviceType api.SCSIDeviceType
SCSIDeviceOps []SCSIDeviceOperation
}
// NewSCSIDeviceOperation create a new SCSI device operation
func NewSCSIDeviceOperation(fn api.CommandFunc, sa []*SCSIServiceAction, pr uint8) SCSIDeviceOperation {
return SCSIDeviceOperation{
CommandPerformFunc: fn,
@@ -139,6 +148,7 @@ func NewSCSIDeviceOperation(fn api.CommandFunc, sa []*SCSIServiceAction, pr uint
}
}
// BuildSenseData build sense data
func BuildSenseData(cmd *api.SCSICommand, key byte, asc SCSISubError) {
senseBuffer := &bytes.Buffer{}
inBufLen, ok := SCSICDBBufXLength(cmd.SCB)