small refactor: combine all package response generation

2016-12-11 18:21:53 +08:00
parent c8d2d89619
commit 42949563ac
3 changed files with 84 additions and 132 deletions
--- a/pkg/port/iscsit/login.go
+++ b/pkg/port/iscsit/login.go
@@ -54,7 +54,7 @@ func loginKVDeclare(conn *iscsiConnection, negoKV []util.KeyValue) []util.KeyVal
 	return negoKV

 }
-func loginKVProcess(conn *iscsiConnection, loginKV map[string]string) ([]util.KeyValue, error) {
+func (conn *iscsiConnection) processLoginData() ([]util.KeyValue, error) {
 	var (
 		uintVal    uint
 		ok         bool
@@ -62,6 +62,7 @@ func loginKVProcess(conn *iscsiConnection, loginKV map[string]string) ([]util.Ke
 		negoKV     []util.KeyValue
 		kvChanges  int
 	)
+	loginKV := util.ParseKVText(conn.req.RawData)

 	for key, val := range loginKV {
 		// The MaxRecvDataSegmentLength of initiator