admin/gotgt
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat: implement cmd management for targets, LUNs, and TPGTs (fixes #36)

Browse Source 
- Fix target delete URL path mismatch (/targets/ -> /target/)
- Implement target create/delete server handlers with proper validation
- Add DeleteTarget method with force flag and mutex locking to SCSITargetService
- Implement full LU management: create/list/delete through CLI, client, and server
- Add TPGT list command to show target portal group tags
- Add unit tests for target/LU router handlers and SCSI service

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Lei Xue
2026-03-14 20:30:47 +08:00
parent bbd373ba0e
commit 93e1476a0f
16 changed files with 760 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
cmd/remove.go
View File

@@ -28,7 +28,7 @@ import (
func newRemoveCommand(cli *client.Client) *cobra.Command {
var cmd = &cobra.Command{
Use: "rm",
Short: "remove a new object",
Short: "Remove an object",
Long: `All software has versions. This is Gotgt 's`,
Run: func(cmd *cobra.Command, args []string) {
fmt.Println(cmd.UsageString())
@@ -45,7 +45,7 @@ func newRemoveTargetCmd(cli *client.Client) *cobra.Command {
opts := api.TargetRemoveOptions{}
var cmd = &cobra.Command{
Use: "target",
Short: "Remove a new target into gotgt",
Short: "Remove a target from gotgt",
Long: `All software has versions. This is Gotgt 's`,
RunE: func(cmd *cobra.Command, args []string) error {
return removeTarget(cli, opts)
@@ -53,23 +53,28 @@ func newRemoveTargetCmd(cli *client.Client) *cobra.Command {
}
flags := cmd.Flags()
flags.StringVar(&opts.Name, "name", "", "Specify target name")
flags.BoolVar(&opts.Force, "force", false, "Specify target name")
flags.BoolVar(&opts.Force, "force", false, "Force removal even with active sessions")
return cmd
}
func newRemoveLuCmd(cli *client.Client) *cobra.Command {
opts := api.LuRemoveOptions{}
var cmd = &cobra.Command{
Use: "lu",
Short: "Remove a new Lu into gotgt",
Long: `All software has versions. This is Gotgt 's`,
Short: "Remove a LU from gotgt",
Long: `Remove a Logical Unit from a target`,
RunE: func(cmd *cobra.Command, args []string) error {
return removeLu(cli)
if err := NoArgs(cmd, args); err != nil {
return err
}
return removeLu(cli, opts)
},
}
flags := cmd.Flags()
_ = flags
flags.StringVar(&opts.TargetName, "target", "", "Specify target name")
flags.Uint64Var(&opts.LUN, "lun", 0, "Specify LUN number")
return cmd
}
@@ -82,6 +87,14 @@ func removeTarget(cli *client.Client, opts api.TargetRemoveOptions) error {
return nil
}
func removeLu(cli *client.Client) error {
func removeLu(cli *client.Client, opts api.LuRemoveOptions) error {
if opts.TargetName == "" {
return fmt.Errorf("target name is required (--target)")
}
err := cli.LuRemove(context.Background(), opts)
if err != nil {
return err
}
fmt.Printf("LU %d successfully removed from target %s\n", opts.LUN, opts.TargetName)
return nil
}