admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use const/let in specs, not var

Browse Source
This commit is contained in:
Steve Gravrock
2022-04-16 13:41:44 -07:00
parent 482dc883eb
commit 1166d10e43
111 changed files with 2522 additions and 2675 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
spec/core/SpySpec.js
View File

@@ -1,5 +1,5 @@
describe('Spies', function() {
var env;
let env;
beforeEach(function() {
env = new jasmineUnderTest.Env();
@@ -10,7 +10,7 @@ describe('Spies', function() {
});
describe('createSpy', function() {
var TestClass;
let TestClass;
beforeEach(function() {
TestClass = function() {};
@@ -19,7 +19,7 @@ describe('Spies', function() {
});
it('preserves the properties of the spied function', function() {
var spy = env.createSpy(
const spy = env.createSpy(
TestClass.prototype,
TestClass.prototype.someFunction
);
@@ -28,8 +28,8 @@ describe('Spies', function() {
});
it('should allow you to omit the name argument and only pass the originalFn argument', function() {
var fn = function test() {};
var spy = env.createSpy(fn);
const fn = function test() {};
const spy = env.createSpy(fn);
expect(spy.and.identity).toEqual('test');
});
@@ -45,7 +45,7 @@ describe('Spies', function() {
});
it('adds a spyStrategy and callTracker to the spy', function() {
var spy = env.createSpy(
const spy = env.createSpy(
TestClass.prototype,
TestClass.prototype.someFunction
);
@@ -55,11 +55,11 @@ describe('Spies', function() {
});
it('tracks the argument of calls', function() {
var spy = env.createSpy(
const spy = env.createSpy(
TestClass.prototype,
TestClass.prototype.someFunction
);
var trackSpy = spyOn(spy.calls, 'track');
const trackSpy = spyOn(spy.calls, 'track');
spy('arg');
@@ -67,24 +67,24 @@ describe('Spies', function() {
});
it('tracks the context of calls', function() {
var spy = env.createSpy(
const spy = env.createSpy(
TestClass.prototype,
TestClass.prototype.someFunction
);
var trackSpy = spyOn(spy.calls, 'track');
const trackSpy = spyOn(spy.calls, 'track');
var contextObject = { spyMethod: spy };
const contextObject = { spyMethod: spy };
contextObject.spyMethod();
expect(trackSpy.calls.mostRecent().args[0].object).toEqual(contextObject);
});
it('tracks the return value of calls', function() {
var spy = env.createSpy(
const spy = env.createSpy(
TestClass.prototype,
TestClass.prototype.someFunction
);
var trackSpy = spyOn(spy.calls, 'track');
const trackSpy = spyOn(spy.calls, 'track');
spy.and.returnValue('return value');
spy();
@@ -95,7 +95,7 @@ describe('Spies', function() {
});
it('preserves arity of original function', function() {
var functions = [
const functions = [
function nullary() {},
// eslint-disable-next-line no-unused-vars
function unary(arg) {},
@@ -111,8 +111,8 @@ describe('Spies', function() {
function senary(arg1, arg2, arg3, arg4, arg5, arg6) {}
];
for (var arity = 0; arity < functions.length; arity++) {
var someFunction = functions[arity],
for (let arity = 0; arity < functions.length; arity++) {
const someFunction = functions[arity],
spy = env.createSpy(someFunction.name, someFunction);
expect(spy.length).toEqual(arity);
@@ -122,7 +122,7 @@ describe('Spies', function() {
describe('createSpyObj', function() {
it('should create an object with spy methods and corresponding return values when you call jasmine.createSpyObj() with an object', function() {
var spyObj = env.createSpyObj('BaseName', {
const spyObj = env.createSpyObj('BaseName', {
method1: 42,
method2: 'special sauce'
});
@@ -135,7 +135,7 @@ describe('Spies', function() {
});
it('should create an object with a bunch of spy methods when you call jasmine.createSpyObj()', function() {
var spyObj = env.createSpyObj('BaseName', ['method1', 'method2']);
const spyObj = env.createSpyObj('BaseName', ['method1', 'method2']);
expect(spyObj).toEqual({
method1: jasmine.any(Function),
@@ -146,7 +146,7 @@ describe('Spies', function() {
});
it('should allow you to omit the baseName', function() {
var spyObj = env.createSpyObj(['method1', 'method2']);
const spyObj = env.createSpyObj(['method1', 'method2']);
expect(spyObj).toEqual({
method1: jasmine.any(Function),
@@ -181,20 +181,20 @@ describe('Spies', function() {
});
it('creates an object with spy properties if a second list is passed', function() {
var spyObj = env.createSpyObj('base', ['method1'], ['prop1']);
const spyObj = env.createSpyObj('base', ['method1'], ['prop1']);
expect(spyObj).toEqual({
method1: jasmine.any(Function),
prop1: undefined
});
var descriptor = Object.getOwnPropertyDescriptor(spyObj, 'prop1');
const descriptor = Object.getOwnPropertyDescriptor(spyObj, 'prop1');
expect(descriptor.get.and.identity).toEqual('base.prop1.get');
expect(descriptor.set.and.identity).toEqual('base.prop1.set');
});
it('creates an object with property names and return values if second object is passed', function() {
var spyObj = env.createSpyObj('base', ['method1'], {
const spyObj = env.createSpyObj('base', ['method1'], {
prop1: 'foo',
prop2: 37
});
@@ -215,7 +215,7 @@ describe('Spies', function() {
});
it('allows base name to be omitted when assigning methods and properties', function() {
var spyObj = env.createSpyObj({ m: 3 }, { p: 4 });
const spyObj = env.createSpyObj({ m: 3 }, { p: 4 });
expect(spyObj.m()).toEqual(3);
expect(spyObj.p).toEqual(4);
@@ -226,7 +226,7 @@ describe('Spies', function() {
});
it('can use different strategies for different arguments', function() {
var spy = env.createSpy('foo');
const spy = env.createSpy('foo');
spy.and.returnValue(42);
spy.withArgs('baz', 'grault').and.returnValue(-1);
spy.withArgs('thud').and.returnValue('bob');
@@ -238,7 +238,7 @@ describe('Spies', function() {
});
it('uses asymmetric equality testers when selecting a strategy', function() {
var spy = env.createSpy('foo');
const spy = env.createSpy('foo');
spy.and.returnValue(42);
spy.withArgs(jasmineUnderTest.any(String)).and.returnValue(-1);
@@ -264,7 +264,7 @@ describe('Spies', function() {
});
it('can reconfigure an argument-specific strategy', function() {
var spy = env.createSpy('foo');
const spy = env.createSpy('foo');
spy.withArgs('foo').and.returnValue(42);
spy.withArgs('foo').and.returnValue(17);
expect(spy('foo')).toEqual(17);
@@ -272,7 +272,7 @@ describe('Spies', function() {
describe('any promise-based strategy', function() {
it('works with global Promise library', function(done) {
var spy = env.createSpy('foo').and.resolveTo(42);
const spy = env.createSpy('foo').and.resolveTo(42);
spy()
.then(function(result) {
expect(result).toEqual(42);
@@ -284,14 +284,14 @@ describe('Spies', function() {
describe('when withArgs is used without a base strategy', function() {
it('uses the matching strategy', function() {
var spy = env.createSpy('foo');
const spy = env.createSpy('foo');
spy.withArgs('baz').and.returnValue(-1);
expect(spy('baz')).toEqual(-1);
});
it("throws if the args don't match", function() {
var spy = env.createSpy('foo');
const spy = env.createSpy('foo');
spy.withArgs('bar').and.returnValue(-1);
expect(function() {