Use const/let in specs, not var

spec/core/matchers/toHaveBeenCalledBeforeSpec.js

@@ -1,6 +1,6 @@
 describe('toHaveBeenCalledBefore', function() {
   it('throws an exception when the actual is not a spy', function() {
-    var matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore({
+    const matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore({
         pp: jasmineUnderTest.makePrettyPrinter()
       }),
       fn = function() {},
@@ -12,7 +12,7 @@ describe('toHaveBeenCalledBefore', function() {
   });
 
   it('throws an exception when the expected is not a spy', function() {
-    var matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore({
+    const matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore({
         pp: jasmineUnderTest.makePrettyPrinter()
       }),
       spy = new jasmineUnderTest.Env().createSpy('a spy'),
@@ -24,7 +24,7 @@ describe('toHaveBeenCalledBefore', function() {
   });
 
   it('fails when the actual was not called', function() {
-    var matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore(),
+    const matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore(),
       firstSpy = new jasmineUnderTest.Spy('first spy'),
       secondSpy = new jasmineUnderTest.Spy('second spy');
 
@@ -38,7 +38,7 @@ describe('toHaveBeenCalledBefore', function() {
   });
 
   it('fails when the expected was not called', function() {
-    var matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore(),
+    const matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore(),
       firstSpy = new jasmineUnderTest.Spy('first spy'),
       secondSpy = new jasmineUnderTest.Spy('second spy');
 
@@ -52,15 +52,14 @@ describe('toHaveBeenCalledBefore', function() {
   });
 
   it('fails when the actual is called after the expected', function() {
-    var matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore(),
+    const matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore(),
       firstSpy = new jasmineUnderTest.Spy('first spy'),
-      secondSpy = new jasmineUnderTest.Spy('second spy'),
-      result;
+      secondSpy = new jasmineUnderTest.Spy('second spy');
 
     secondSpy();
     firstSpy();
 
-    result = matcher.compare(firstSpy, secondSpy);
+    const result = matcher.compare(firstSpy, secondSpy);
     expect(result.pass).toBe(false);
     expect(result.message).toEqual(
       'Expected spy first spy to have been called before spy second spy'
@@ -68,16 +67,15 @@ describe('toHaveBeenCalledBefore', function() {
   });
 
   it('fails when the actual is called before and after the expected', function() {
-    var matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore(),
+    const matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore(),
       firstSpy = new jasmineUnderTest.Spy('first spy'),
-      secondSpy = new jasmineUnderTest.Spy('second spy'),
-      result;
+      secondSpy = new jasmineUnderTest.Spy('second spy');
 
     firstSpy();
     secondSpy();
     firstSpy();
 
-    result = matcher.compare(firstSpy, secondSpy);
+    const result = matcher.compare(firstSpy, secondSpy);
     expect(result.pass).toBe(false);
     expect(result.message).toEqual(
       'Expected latest call to spy first spy to have been called before first call to spy second spy (no interleaved calls)'
@@ -85,16 +83,15 @@ describe('toHaveBeenCalledBefore', function() {
   });
 
   it('fails when the expected is called before and after the actual', function() {
-    var matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore(),
+    const matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore(),
       firstSpy = new jasmineUnderTest.Spy('first spy'),
-      secondSpy = new jasmineUnderTest.Spy('second spy'),
-      result;
+      secondSpy = new jasmineUnderTest.Spy('second spy');
 
     secondSpy();
     firstSpy();
     secondSpy();
 
-    result = matcher.compare(firstSpy, secondSpy);
+    const result = matcher.compare(firstSpy, secondSpy);
     expect(result.pass).toBe(false);
     expect(result.message).toEqual(
       'Expected first call to spy second spy to have been called after latest call to spy first spy (no interleaved calls)'
@@ -102,15 +99,14 @@ describe('toHaveBeenCalledBefore', function() {
   });
 
   it('passes when the actual is called before the expected', function() {
-    var matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore(),
+    const matcher = jasmineUnderTest.matchers.toHaveBeenCalledBefore(),
       firstSpy = new jasmineUnderTest.Spy('first spy'),
-      secondSpy = new jasmineUnderTest.Spy('second spy'),
-      result;
+      secondSpy = new jasmineUnderTest.Spy('second spy');
 
     firstSpy();
     secondSpy();
 
-    result = matcher.compare(firstSpy, secondSpy);
+    const result = matcher.compare(firstSpy, secondSpy);
     expect(result.pass).toBe(true);
     expect(result.message).toEqual(
       'Expected spy first spy to not have been called before spy second spy, but it was'