Report the message when a browser error event with a message but no error occurs

This commit is contained in:
Steve Gravrock
2024-03-21 09:15:43 -07:00
parent 99e350ac85
commit 1504f25ced
3 changed files with 90 additions and 12 deletions

View File

@@ -65,8 +65,8 @@ getJasmineRequireObj().QueueRunner = function(j$) {
}
QueueRunner.prototype.execute = function() {
this.handleFinalError = error => {
this.onException(error);
this.handleFinalError = (error, event) => {
this.onException(errorOrMsgForGlobalError(error, event));
};
this.globalErrors.pushListener(this.handleFinalError);
this.run(0);
@@ -96,10 +96,8 @@ getJasmineRequireObj().QueueRunner = function(j$) {
this.recordError_(iterativeIndex);
};
function handleError(error) {
// TODO probably shouldn't next() right away here.
// That makes debugging async failures much more confusing.
onException(error);
function handleError(error, event) {
onException(errorOrMsgForGlobalError(error, event));
}
const cleanup = once(() => {
if (timeoutId !== void 0) {
@@ -285,5 +283,16 @@ getJasmineRequireObj().QueueRunner = function(j$) {
};
}
function errorOrMsgForGlobalError(error, event) {
// TODO: In cases where error is a string or undefined, the error message
// that gets sent to reporters will be `${message} thrown`, which could
// be improved to not say "thrown" when the cause wasn't necessarily
// an exception or to provide hints about throwing Errors rather than
// strings.
return (
error || (event && event.message) || 'Global error event with no message'
);
}
return QueueRunner;
};