Merge branch 'patch-1' of https://github.com/nitobuendia/jasmine into nitobuendia-patch-1
- Merges #1601 from @nitobuendia - Fixes #1594
This commit is contained in:
@@ -2851,6 +2851,8 @@ getJasmineRequireObj().ExceptionFormatter = function(j$) {
|
|||||||
|
|
||||||
if (error.name && error.message) {
|
if (error.name && error.message) {
|
||||||
message += error.name + ': ' + error.message;
|
message += error.name + ': ' + error.message;
|
||||||
|
} else if (error.message) {
|
||||||
|
message += error.message;
|
||||||
} else {
|
} else {
|
||||||
message += error.toString() + ' thrown';
|
message += error.toString() + ' thrown';
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -37,6 +37,28 @@ describe("ExceptionFormatter", function() {
|
|||||||
expect(message).toEqual('A Classic Mistake: you got your foo in my bar');
|
expect(message).toEqual('A Classic Mistake: you got your foo in my bar');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('formats unnamed exceptions with message', function() {
|
||||||
|
var unnamedError = {message: 'This is an unnamed error message.'};
|
||||||
|
|
||||||
|
var exceptionFormatter = new jasmineUnderTest.ExceptionFormatter(),
|
||||||
|
message = exceptionFormatter.message(unnamedError);
|
||||||
|
|
||||||
|
expect(message).toEqual('This is an unnamed error message.');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('formats empty exceptions with toString format', function() {
|
||||||
|
var EmptyError = function() {};
|
||||||
|
EmptyError.prototype.toString = function() {
|
||||||
|
return '[EmptyError]';
|
||||||
|
};
|
||||||
|
var emptyError = new EmptyError();
|
||||||
|
|
||||||
|
var exceptionFormatter = new jasmineUnderTest.ExceptionFormatter(),
|
||||||
|
message = exceptionFormatter.message(emptyError);
|
||||||
|
|
||||||
|
expect(message).toEqual('[EmptyError] thrown');
|
||||||
|
});
|
||||||
|
|
||||||
it("formats thrown exceptions that aren't errors", function() {
|
it("formats thrown exceptions that aren't errors", function() {
|
||||||
var thrown = "crazy error",
|
var thrown = "crazy error",
|
||||||
exceptionFormatter = new jasmineUnderTest.ExceptionFormatter(),
|
exceptionFormatter = new jasmineUnderTest.ExceptionFormatter(),
|
||||||
|
|||||||
@@ -7,6 +7,8 @@ getJasmineRequireObj().ExceptionFormatter = function(j$) {
|
|||||||
|
|
||||||
if (error.name && error.message) {
|
if (error.name && error.message) {
|
||||||
message += error.name + ': ' + error.message;
|
message += error.name + ': ' + error.message;
|
||||||
|
} else if (error.message) {
|
||||||
|
message += error.message;
|
||||||
} else {
|
} else {
|
||||||
message += error.toString() + ' thrown';
|
message += error.toString() + ' thrown';
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user