admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor Suite.addSpec and .addSuite to .addChild

Browse Source
This commit is contained in:
Sheel Choksi and Tim Jarratt
2013-10-25 10:52:31 -07:00
parent 26581b4c91
commit 29c5c127e5
3 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/core/SuiteSpec.js
View File

@@ -106,8 +106,8 @@ describe("Suite", function() {
spyOn(suite, "execute"); spyOn(suite, "execute");
parentSuite.addSpec(fakeSpec1); parentSuite.addChild(fakeSpec1);
parentSuite.addSuite(suite); parentSuite.addChild(suite);
parentSuite.execute(parentSuiteDone); parentSuite.execute(parentSuiteDone);

4
src/core/Env.js
View File

@@ -223,7 +223,7 @@ getJasmineRequireObj().Env = function(j$) {
var suite = suiteFactory(description); var suite = suiteFactory(description);
var parentSuite = currentSuite; var parentSuite = currentSuite;
parentSuite.addSuite(suite); parentSuite.addChild(suite);
currentSuite = suite; currentSuite = suite;
var declarationError = null; var declarationError = null;
@@ -302,7 +302,7 @@ getJasmineRequireObj().Env = function(j$) {
this.it = function(description, fn) { this.it = function(description, fn) {
var spec = specFactory(description, fn, currentSuite); var spec = specFactory(description, fn, currentSuite);
currentSuite.addSpec(spec); currentSuite.addChild(spec);
return spec; return spec;
}; };

9
src/core/Suite.js
View File

@@ -45,13 +45,8 @@ getJasmineRequireObj().Suite = function() {
this.afterFns.unshift(fn); this.afterFns.unshift(fn);
}; };
Suite.prototype.addSpec = function(spec) { Suite.prototype.addChild = function(child) {
this.children.push(spec); this.children.push(child);
};
Suite.prototype.addSuite = function(suite) {
suite.parentSuite = this;
this.children.push(suite);
}; };
Suite.prototype.execute = function(onComplete) { Suite.prototype.execute = function(onComplete) {