Don't deprecate access to Suite#id and Spec#id

This commit is contained in:
Steve Gravrock
2021-07-29 20:15:04 -07:00
parent a0b4f3748d
commit 2a2a671b65
4 changed files with 7 additions and 2 deletions

View File

@@ -3736,7 +3736,7 @@ getJasmineRequireObj().deprecatingSpecProxy = function(j$) {
} }
function isAllowedMember(prop) { function isAllowedMember(prop) {
return prop === 'description' || prop === 'getFullName'; return prop === 'id' || prop === 'description' || prop === 'getFullName';
} }
function msg(member) { function msg(member) {
@@ -3800,6 +3800,7 @@ getJasmineRequireObj().deprecatingSpecProxy = function(j$) {
// TODO: Remove this in the next major release. // TODO: Remove this in the next major release.
getJasmineRequireObj().deprecatingSuiteProxy = function(j$) { getJasmineRequireObj().deprecatingSuiteProxy = function(j$) {
var allowedMembers = [ var allowedMembers = [
'id',
'children', 'children',
'description', 'description',
'parentSuite', 'parentSuite',

View File

@@ -87,14 +87,17 @@ describe('Env', function() {
}); });
suite = env.topSuite(); suite = env.topSuite();
suite.id;
suite.description; suite.description;
suite.getFullName(); suite.getFullName();
suite.children; suite.children;
suite.parentSuite; suite.parentSuite;
suite.children[0].id;
suite.children[0].description; suite.children[0].description;
suite.children[0].getFullName(); suite.children[0].getFullName();
suite.children[0].children; suite.children[0].children;
suite.children[1].id;
suite.children[1].description; suite.children[1].description;
suite.children[1].getFullName(); suite.children[1].getFullName();
suite.children[1].parentSuite; suite.children[1].parentSuite;

View File

@@ -9,7 +9,7 @@ getJasmineRequireObj().deprecatingSpecProxy = function(j$) {
} }
function isAllowedMember(prop) { function isAllowedMember(prop) {
return prop === 'description' || prop === 'getFullName'; return prop === 'id' || prop === 'description' || prop === 'getFullName';
} }
function msg(member) { function msg(member) {

View File

@@ -2,6 +2,7 @@
// TODO: Remove this in the next major release. // TODO: Remove this in the next major release.
getJasmineRequireObj().deprecatingSuiteProxy = function(j$) { getJasmineRequireObj().deprecatingSuiteProxy = function(j$) {
var allowedMembers = [ var allowedMembers = [
'id',
'children', 'children',
'description', 'description',
'parentSuite', 'parentSuite',