admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow createSpyObj to be called with just an array of method names

Browse Source 
[Finish #50757607] #321
This commit is contained in:
Gregg Van Hove
2015-01-12 15:16:50 -08:00
parent 69a61547e7
commit 3140d5fb95
3 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/jasmine-core/jasmine.js
View File

@@ -209,6 +209,11 @@ getJasmineRequireObj().base = function(j$, jasmineGlobal) {
}; };
j$.createSpyObj = function(baseName, methodNames) { j$.createSpyObj = function(baseName, methodNames) {
if (j$.isArray_(baseName) && j$.util.isUndefined(methodNames)) {
methodNames = baseName;
baseName = 'unknown';
}
if (!j$.isArray_(methodNames) || methodNames.length === 0) { if (!j$.isArray_(methodNames) || methodNames.length === 0) {
throw 'createSpyObj requires a non-empty array of method names to create spies for'; throw 'createSpyObj requires a non-empty array of method names to create spies for';
} }

8
spec/core/SpySpec.js
View File

@@ -68,6 +68,14 @@ describe('Spies', function () {
expect(spyObj.method2.and.identity()).toEqual('BaseName.method2'); expect(spyObj.method2.and.identity()).toEqual('BaseName.method2');
}); });
it("should allow you to omit the baseName", function() {
var spyObj = j$.createSpyObj(['method1', 'method2']);
expect(spyObj).toEqual({ method1: jasmine.any(Function), method2: jasmine.any(Function)});
expect(spyObj.method1.and.identity()).toEqual('unknown.method1');
expect(spyObj.method2.and.identity()).toEqual('unknown.method2');
});
it("should throw if you do not pass an array argument", function() { it("should throw if you do not pass an array argument", function() {
expect(function() { expect(function() {
j$.createSpyObj('BaseName'); j$.createSpyObj('BaseName');

5
src/core/base.js
View File

@@ -105,6 +105,11 @@ getJasmineRequireObj().base = function(j$, jasmineGlobal) {
}; };
j$.createSpyObj = function(baseName, methodNames) { j$.createSpyObj = function(baseName, methodNames) {
if (j$.isArray_(baseName) && j$.util.isUndefined(methodNames)) {
methodNames = baseName;
baseName = 'unknown';
}
if (!j$.isArray_(methodNames) || methodNames.length === 0) { if (!j$.isArray_(methodNames) || methodNames.length === 0) {
throw 'createSpyObj requires a non-empty array of method names to create spies for'; throw 'createSpyObj requires a non-empty array of method names to create spies for';
} }