From 390cc45af258854745cca00d148d1f74ebc45289 Mon Sep 17 00:00:00 2001 From: Steve Gravrock Date: Thu, 27 Apr 2023 19:23:47 -0700 Subject: [PATCH] Dropped support for Node 16 Node 16 will reach EOL no later than a few months after Jasmine 5 is released. Experience with Node 12 and Node 14 has shown that our dependencies, especially dev dependencies, move on from past-EOL Node versions fairly quickly. That can make it difficult to continue supporting them. Since long term support for past EOL Node versions is a non-goal and many users expect that Node versions will only be dropped in major releases, it's better to drop it in 5.0. --- .circleci/config.yml | 28 +++++++--------------------- README.md | 2 +- 2 files changed, 8 insertions(+), 22 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index ae0e46fc..36c942c7 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -12,12 +12,6 @@ executors: docker: - image: cimg/node:18.0.0 working_directory: ~/workspace - node16: - docker: - # Oldest version with reliable support for error cause property, - # which jasmine-npm uses. - - image: cimg/node:16.14.0 - working_directory: ~/workspace jobs: build: @@ -66,7 +60,7 @@ jobs: command: npx grunt execSpecsInParallel test_browsers: &test_browsers - executor: node16 + executor: node18 steps: - attach_workspace: at: . @@ -106,9 +100,6 @@ workflows: - build: executor: node18 name: build_node_18 - - build: - executor: node16 - name: build_node_16 - test_node: executor: node20 name: test_node_20 @@ -119,24 +110,19 @@ workflows: name: test_node_18 requires: - build_node_18 - - test_node: - executor: node16 - name: test_node_16 - requires: - - build_node_16 - - test_parallel: - executor: node16 - name: test_parallel_node_16 - requires: - - build_node_16 - test_parallel: executor: node18 name: test_parallel_node_18 requires: - build_node_18 + - test_parallel: + executor: node20 + name: test_parallel_node_20 + requires: + - build_node_20 - test_browsers: requires: - - build_node_16 + - build_node_18 filters: branches: ignore: /pull\/.*/ # Don't run on pull requests. diff --git a/README.md b/README.md index 8536d021..9d1212ec 100644 --- a/README.md +++ b/README.md @@ -32,7 +32,7 @@ Microsoft Edge) as well as Node. | Environment | Supported versions | |-------------------|---------------------| -| Node | 16.14-16.19, 18, 20 | +| Node | 18, 20 | | Safari | 15-16 | | Chrome | Evergreen | | Firefox | Evergreen, 102 |