Also show tip for .not cases

This commit is contained in:
Gregg Van Hove
2018-10-22 10:57:16 -07:00
parent 7cbedcdda7
commit 3c47e71619
2 changed files with 38 additions and 14 deletions

View File

@@ -1,14 +1,34 @@
describe("toBe", function() { describe("toBe", function() {
it("passes when actual === expected", function() { it("passes with no message when actual === expected", function() {
var matcher = jasmineUnderTest.matchers.toBe(), var matcher = jasmineUnderTest.matchers.toBe(jasmineUnderTest.matchersUtil),
result; result;
result = matcher.compare(1, 1); result = matcher.compare(1, 1);
expect(result.pass).toBe(true); expect(result.pass).toBe(true);
}); });
it("passes with a custom message when expected is an array", function() {
var matcher = jasmineUnderTest.matchers.toBe(jasmineUnderTest.matchersUtil),
result,
array = [1];
result = matcher.compare(array, array);
expect(result.pass).toBe(true);
expect(result.message).toBe("Expected [ 1 ] not to be [ 1 ]. Tip: To check for deep equality, use .toEqual() instead of .toBe().")
});
it("passes with a custom message when expected is an object", function() {
var matcher = jasmineUnderTest.matchers.toBe(jasmineUnderTest.matchersUtil),
result,
obj = {foo: "bar"};
result = matcher.compare(obj, obj);
expect(result.pass).toBe(true);
expect(result.message).toBe("Expected Object({ foo: 'bar' }) not to be Object({ foo: 'bar' }). Tip: To check for deep equality, use .toEqual() instead of .toBe().")
});
it("fails with no message when actual !== expected", function() { it("fails with no message when actual !== expected", function() {
var matcher = jasmineUnderTest.matchers.toBe(), var matcher = jasmineUnderTest.matchers.toBe(jasmineUnderTest.matchersUtil),
result; result;
result = matcher.compare(1, 2); result = matcher.compare(1, 2);
@@ -17,8 +37,8 @@ describe("toBe", function() {
}); });
it("fails with a custom message when expected is an array", function() { it("fails with a custom message when expected is an array", function() {
var matcher = jasmineUnderTest.matchers.toBe(), var matcher = jasmineUnderTest.matchers.toBe(jasmineUnderTest.matchersUtil),
result; result;
result = matcher.compare([1], [1]); result = matcher.compare([1], [1]);
expect(result.pass).toBe(false); expect(result.pass).toBe(false);
@@ -26,8 +46,8 @@ describe("toBe", function() {
}); });
it("fails with a custom message when expected is an object", function() { it("fails with a custom message when expected is an object", function() {
var matcher = jasmineUnderTest.matchers.toBe(), var matcher = jasmineUnderTest.matchers.toBe(jasmineUnderTest.matchersUtil),
result; result;
result = matcher.compare({foo: "bar"}, {foo: "bar"}); result = matcher.compare({foo: "bar"}, {foo: "bar"});
expect(result.pass).toBe(false); expect(result.pass).toBe(false);

View File

@@ -1,4 +1,4 @@
getJasmineRequireObj().toBe = function($j) { getJasmineRequireObj().toBe = function(j$) {
/** /**
* {@link expect} the actual value to be `===` to the expected value. * {@link expect} the actual value to be `===` to the expected value.
* @function * @function
@@ -7,16 +7,20 @@ getJasmineRequireObj().toBe = function($j) {
* @example * @example
* expect(thing).toBe(realThing); * expect(thing).toBe(realThing);
*/ */
function toBe() { function toBe(util) {
var tip = ' Tip: To check for deep equality, use .toEqual() instead of .toBe().';
return { return {
compare: function(actual, expected) { compare: function(actual, expected) {
var customMessage = 'Expected ' + $j.pp(expected) + ' to be ' + $j.pp(actual) + '. Tip: To check for deep equality, use .toEqual() instead of .toBe().'; var result = {
return {
pass: actual === expected, pass: actual === expected,
message: typeof expected === 'object' ? customMessage : undefined,
}; };
if (typeof expected === 'object') {
result.message = util.buildFailureMessage('toBe', result.pass, actual, expected) + tip;
}
return result;
} }
}; };
} }