admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use one declaration per statement

Browse Source 
The old style of merging all of a function's variable declarations into
a single statement made some sense back in the days of var, but there's
no reason to keep doing it now that we use const and let.
This commit is contained in:
Steve Gravrock
2026-03-10 20:02:42 -07:00
parent 03ebebf6fb
commit 434575f49d
88 changed files with 3650 additions and 3604 deletions
Download Patch File Download Diff File Expand all files Collapse all files

578
spec/core/ExpectationSpec.js
View File

@@ -1,12 +1,12 @@
describe('Expectation', function() {
it('makes custom matchers available to this expectation', function() {
const matchers = {
toFoo: function() {},
toBar: function() {}
},
expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers
});
toFoo: function() {},
toBar: function() {}
};
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers
});
expect(expectation.toFoo).toBeDefined();
expect(expectation.toBar).toBeDefined();
@@ -26,18 +26,18 @@ describe('Expectation', function() {
it("wraps matchers's compare functions, passing in matcher dependencies", function() {
const fakeCompare = function() {
return { pass: true };
},
matcherFactory = jasmine
.createSpy('matcher')
.and.returnValue({ compare: fakeCompare }),
matchers = {
toFoo: matcherFactory
},
matchersUtil = {
buildFailureMessage: jasmine.createSpy('buildFailureMessage')
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
return { pass: true };
};
const matcherFactory = jasmine
.createSpy('matcher')
.and.returnValue({ compare: fakeCompare });
const matchers = {
toFoo: matcherFactory
};
const matchersUtil = {
buildFailureMessage: jasmine.createSpy('buildFailureMessage')
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
matchersUtil: matchersUtil,
@@ -53,19 +53,19 @@ describe('Expectation', function() {
it("wraps matchers's compare functions, passing the actual and expected", function() {
const fakeCompare = jasmine
.createSpy('fake-compare')
.and.returnValue({ pass: true }),
matchers = {
toFoo: function() {
return {
compare: fakeCompare
};
}
},
matchersUtil = {
buildFailureMessage: jasmine.createSpy('buildFailureMessage')
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
.createSpy('fake-compare')
.and.returnValue({ pass: true });
const matchers = {
toFoo: function() {
return {
compare: fakeCompare
};
}
};
const matchersUtil = {
buildFailureMessage: jasmine.createSpy('buildFailureMessage')
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
matchersUtil: matchersUtil,
@@ -81,18 +81,18 @@ describe('Expectation', function() {
it('reports a passing result to the spec when the comparison passes', function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return { pass: true };
}
};
}
},
matchersUtil = {
buildFailureMessage: jasmine.createSpy('buildFailureMessage')
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
toFoo: function() {
return {
compare: function() {
return { pass: true };
}
};
}
};
const matchersUtil = {
buildFailureMessage: jasmine.createSpy('buildFailureMessage')
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
@@ -114,20 +114,20 @@ describe('Expectation', function() {
it('reports a failing result to the spec when the comparison fails', function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return { pass: false };
}
};
}
},
matchersUtil = {
buildFailureMessage: function() {
return '';
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
toFoo: function() {
return {
compare: function() {
return { pass: false };
}
};
}
};
const matchersUtil = {
buildFailureMessage: function() {
return '';
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
@@ -149,18 +149,18 @@ describe('Expectation', function() {
it('reports a failing result and a custom fail message to the spec when the comparison fails', function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return {
pass: false,
message: 'I am a custom message'
};
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
toFoo: function() {
return {
compare: function() {
return {
pass: false,
message: 'I am a custom message'
};
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
actual: 'an actual',
@@ -181,20 +181,20 @@ describe('Expectation', function() {
it('reports a failing result with a custom fail message function to the spec when the comparison fails', function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return {
pass: false,
message: function() {
return 'I am a custom message';
}
};
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
toFoo: function() {
return {
compare: function() {
return {
pass: false,
message: function() {
return 'I am a custom message';
}
};
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
@@ -215,15 +215,15 @@ describe('Expectation', function() {
it('reports a passing result to the spec when the comparison fails for a negative expectation', function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return { pass: false };
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
toFoo: function() {
return {
compare: function() {
return { pass: false };
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
@@ -244,20 +244,20 @@ describe('Expectation', function() {
it('reports a failing result to the spec when the comparison passes for a negative expectation', function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return { pass: true };
}
};
}
},
matchersUtil = {
buildFailureMessage: function() {
return 'default message';
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
toFoo: function() {
return {
compare: function() {
return { pass: true };
}
};
}
};
const matchersUtil = {
buildFailureMessage: function() {
return 'default message';
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
@@ -279,18 +279,18 @@ describe('Expectation', function() {
it('reports a failing result and a custom fail message to the spec when the comparison passes for a negative expectation', function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return {
pass: true,
message: 'I am a custom message'
};
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
toFoo: function() {
return {
compare: function() {
return {
pass: true,
message: 'I am a custom message'
};
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
@@ -311,18 +311,18 @@ describe('Expectation', function() {
it("reports a passing result to the spec when the 'not' comparison passes, given a negativeCompare", function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return { pass: true };
},
negativeCompare: function() {
return { pass: true };
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
toFoo: function() {
return {
compare: function() {
return { pass: true };
},
negativeCompare: function() {
return { pass: true };
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
@@ -343,21 +343,21 @@ describe('Expectation', function() {
it("reports a failing result and a custom fail message to the spec when the 'not' comparison fails, given a negativeCompare", function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return { pass: true };
},
negativeCompare: function() {
return {
pass: false,
message: "I'm a custom message"
};
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
toFoo: function() {
return {
compare: function() {
return { pass: true };
},
negativeCompare: function() {
return {
pass: false,
message: "I'm a custom message"
};
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
@@ -379,19 +379,19 @@ describe('Expectation', function() {
it('reports a custom error message to the spec', function() {
const customError = new Error('I am a custom error');
const matchers = {
toFoo: function() {
return {
compare: function() {
return {
pass: false,
message: 'I am a custom message',
error: customError
};
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
toFoo: function() {
return {
compare: function() {
return {
pass: false,
message: 'I am a custom message',
error: customError
};
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
actual: 'an actual',
@@ -413,19 +413,19 @@ describe('Expectation', function() {
it("reports a custom message to the spec when a 'not' comparison fails", function() {
const customError = new Error('I am a custom error');
const matchers = {
toFoo: function() {
return {
compare: function() {
return {
pass: true,
message: 'I am a custom message',
error: customError
};
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
toFoo: function() {
return {
compare: function() {
return {
pass: true,
message: 'I am a custom message',
error: customError
};
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
actual: 'an actual',
@@ -447,21 +447,21 @@ describe('Expectation', function() {
it("reports a custom message func to the spec when a 'not' comparison fails", function() {
const customError = new Error('I am a custom error');
const matchers = {
toFoo: function() {
return {
compare: function() {
return {
pass: true,
message: function() {
return 'I am a custom message';
},
error: customError
};
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult');
toFoo: function() {
return {
compare: function() {
return {
pass: true,
message: function() {
return 'I am a custom message';
},
error: customError
};
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
actual: 'an actual',
@@ -483,26 +483,26 @@ describe('Expectation', function() {
describe('#withContext', function() {
it('prepends the context to the generated failure message', function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return { pass: false };
}
};
}
},
matchersUtil = {
buildFailureMessage: function() {
return 'failure message';
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult'),
expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
matchersUtil: matchersUtil,
actual: 'an actual',
addExpectationResult: addExpectationResult
});
toFoo: function() {
return {
compare: function() {
return { pass: false };
}
};
}
};
const matchersUtil = {
buildFailureMessage: function() {
return 'failure message';
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
matchersUtil: matchersUtil,
actual: 'an actual',
addExpectationResult: addExpectationResult
});
expectation.withContext('Some context').toFoo('hello');
@@ -516,20 +516,20 @@ describe('Expectation', function() {
it('prepends the context to a custom failure message', function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return { pass: false, message: 'msg' };
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult'),
expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
actual: 'an actual',
addExpectationResult: addExpectationResult
});
toFoo: function() {
return {
compare: function() {
return { pass: false, message: 'msg' };
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
actual: 'an actual',
addExpectationResult: addExpectationResult
});
expectation.withContext('Some context').toFoo('hello');
@@ -543,20 +543,20 @@ describe('Expectation', function() {
it('indents a multiline failure message', function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return { pass: false, message: 'a\nmultiline\nmessage' };
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult'),
expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
actual: 'an actual',
addExpectationResult: addExpectationResult
});
toFoo: function() {
return {
compare: function() {
return { pass: false, message: 'a\nmultiline\nmessage' };
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
actual: 'an actual',
addExpectationResult: addExpectationResult
});
expectation.withContext('Some context').toFoo('hello');
@@ -568,25 +568,25 @@ describe('Expectation', function() {
it('prepends the context to a custom failure message from a function', function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return {
pass: false,
message: function() {
return 'msg';
}
};
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult'),
expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
actual: 'an actual',
addExpectationResult: addExpectationResult
});
toFoo: function() {
return {
compare: function() {
return {
pass: false,
message: function() {
return 'msg';
}
};
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
actual: 'an actual',
addExpectationResult: addExpectationResult
});
expectation.withContext('Some context').toFoo('hello');
@@ -600,22 +600,22 @@ describe('Expectation', function() {
it('works with #not', function() {
const matchers = {
toFoo: function() {
return {
compare: function() {
return { pass: true };
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult'),
pp = privateUnderTest.makePrettyPrinter(),
expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
matchersUtil: new privateUnderTest.MatchersUtil({ pp: pp }),
actual: 'an actual',
addExpectationResult: addExpectationResult
});
toFoo: function() {
return {
compare: function() {
return { pass: true };
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const pp = privateUnderTest.makePrettyPrinter();
const expectation = privateUnderTest.Expectation.factory({
customMatchers: matchers,
matchersUtil: new privateUnderTest.MatchersUtil({ pp: pp }),
actual: 'an actual',
addExpectationResult: addExpectationResult
});
expectation.withContext('Some context').not.toFoo();
@@ -630,26 +630,26 @@ describe('Expectation', function() {
it('works with #not and a custom message', function() {
const customError = new Error('I am a custom error');
const matchers = {
toFoo: function() {
return {
compare: function() {
return {
pass: true,
message: function() {
return 'I am a custom message';
},
error: customError
};
}
};
}
},
addExpectationResult = jasmine.createSpy('addExpectationResult'),
expectation = privateUnderTest.Expectation.factory({
actual: 'an actual',
customMatchers: matchers,
addExpectationResult: addExpectationResult
});
toFoo: function() {
return {
compare: function() {
return {
pass: true,
message: function() {
return 'I am a custom message';
},
error: customError
};
}
};
}
};
const addExpectationResult = jasmine.createSpy('addExpectationResult');
const expectation = privateUnderTest.Expectation.factory({
actual: 'an actual',
customMatchers: matchers,
addExpectationResult: addExpectationResult
});
expectation.withContext('Some context').not.toFoo('hello');