admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Move knowledge of query parameters out of boot1.js"

Browse Source 
This reverts commit 6715f24fd0.
This commit is contained in:
Steve Gravrock
2025-10-05 09:54:25 -07:00
parent c590095662
commit 489b83c61b
7 changed files with 58 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
spec/html/HtmlExactSpecFilterSpec.js
View File

@@ -1,10 +1,8 @@
describe('HtmlExactSpecFilter', function() {
it('matches everything when no string is provided', function() {
const specFilter = new jasmineUnderTest.HtmlExactSpecFilter({
queryString: {
getParam(name) {
return '';
}
filterString() {
return '';
}
});
@@ -13,12 +11,8 @@ describe('HtmlExactSpecFilter', function() {
it('matches a spec with the exact same path', function() {
const specFilter = new jasmineUnderTest.HtmlExactSpecFilter({
queryString: {
getParam(name) {
if (name === 'spec') {
return '["a","b","c"]';
}
}
filterString() {
return '["a","b","c"]';
}
});
@@ -27,12 +21,8 @@ describe('HtmlExactSpecFilter', function() {
it('matches a spec whose path has the filter path as a prefix', function() {
const specFilter = new jasmineUnderTest.HtmlExactSpecFilter({
queryString: {
getParam(name) {
if (name === 'spec') {
return '["a","b"]';
}
}
filterString() {
return '["a","b"]';
}
});
@@ -41,12 +31,8 @@ describe('HtmlExactSpecFilter', function() {
it('does not match a spec with a different path', function() {
const specFilter = new jasmineUnderTest.HtmlExactSpecFilter({
queryString: {
getParam(name) {
if (name === 'spec') {
return '["a","b","c"]';
}
}
filterString() {
return '["a","b","c"]';
}
});

19
spec/html/HtmlReporterSpec.js
View File

@@ -1368,11 +1368,6 @@ describe('HtmlReporter', function() {
},
createTextNode: function() {
return document.createTextNode.apply(document, arguments);
},
queryString: {
getParam(name) {
return '';
}
}
};
specStatus = {
@@ -1387,12 +1382,7 @@ describe('HtmlReporter', function() {
describe('when the specs are not filtered', function() {
beforeEach(function() {
reporterConfig.queryString.getParam = function(name) {
if (name !== 'spec') {
throw new Error('Unexpected query param ' + name);
}
return '';
};
reporterConfig.filterSpecs = false;
reporter = new jasmineUnderTest.HtmlReporter(reporterConfig);
reporter.initialize();
reporter.jasmineStarted({ totalSpecsDefined: 1 });
@@ -1410,12 +1400,7 @@ describe('HtmlReporter', function() {
describe('when the specs are filtered', function() {
beforeEach(function() {
reporterConfig.queryString.getParam = function(name) {
if (name !== 'spec') {
throw new Error('Unexpected query param ' + name);
}
return 'not the empty string';
};
reporterConfig.filterSpecs = true;
reporter = new jasmineUnderTest.HtmlReporter(reporterConfig);
reporter.initialize();
reporter.jasmineStarted({ totalSpecsDefined: 1 });