Update immediate goals.
- This commit should get rebased out before merging to master
This commit is contained in:
18
GOALS_2.0.md
18
GOALS_2.0.md
@@ -7,4 +7,22 @@
|
|||||||
* Properties aren't encapsulated -- can be mutated, unsafe.
|
* Properties aren't encapsulated -- can be mutated, unsafe.
|
||||||
1. Reporters get data objects (no methods).
|
1. Reporters get data objects (no methods).
|
||||||
* easier to refactor as needed
|
* easier to refactor as needed
|
||||||
|
1. More unit tests - fewer nasty integration tests
|
||||||
|
|
||||||
|
## Remaining non-story-able work:
|
||||||
|
* Make a `TODO` list
|
||||||
|
|
||||||
|
### Hard
|
||||||
|
* Finish killing Globals
|
||||||
|
* Guidlines: everything that isn't a CTOR should be closed inside `Env`, and everything that is a CTOR needs to be `new`ed inside the `Env`
|
||||||
|
* Spies
|
||||||
|
* jasmine.util should be util closure inside of env or something
|
||||||
|
* Suites need to be unit-tested
|
||||||
|
* Remove Queue from Suite in favor of queuerunner refactoring
|
||||||
|
* Remover Runner in favor of a top-level Suite
|
||||||
|
* This means Env needs to `new` a `Suite` first thing
|
||||||
|
* get feature parity back on HTMLReporter
|
||||||
|
|
||||||
|
### Easy
|
||||||
|
* Refactor `queuerunner` into a new object
|
||||||
|
* xdescribe / xit make skipped specs instead of empty blocks
|
||||||
|
|||||||
@@ -42,6 +42,7 @@ jasmine.HtmlReporter.ReporterView = function(dom, jasmine, catchExceptions) {
|
|||||||
this.specComplete = function(result) {
|
this.specComplete = function(result) {
|
||||||
this.completeSpecCount++;
|
this.completeSpecCount++;
|
||||||
|
|
||||||
|
//TODO: this needs to work in order to get blanks for skipped specs.
|
||||||
// if (isUndefined(this.views.specs[result.id])) {
|
// if (isUndefined(this.views.specs[result.id])) {
|
||||||
// this.views.specs[result.id] = new this.jasmine.HtmlReporter.SpecView(result, dom);
|
// this.views.specs[result.id] = new this.jasmine.HtmlReporter.SpecView(result, dom);
|
||||||
// }
|
// }
|
||||||
|
|||||||
Reference in New Issue
Block a user