diff --git a/lib/jasmine-core/jasmine-html.js b/lib/jasmine-core/jasmine-html.js index c14548cc..14ff61a3 100644 --- a/lib/jasmine-core/jasmine-html.js +++ b/lib/jasmine-core/jasmine-html.js @@ -418,11 +418,11 @@ jasmineRequire.AlertsView = function(j$) { } addDuration(ms) { - this.add('jasmine-duration', 'finished in ' + ms / 1000 + 's'); + this.#add('jasmine-duration', 'finished in ' + ms / 1000 + 's'); } addSkipped(numExecuted, numDefined) { - this.add( + this.#add( 'jasmine-bar jasmine-skipped', createDom( 'a', @@ -454,18 +454,18 @@ jasmineRequire.AlertsView = function(j$) { return false; }; - this.add('jasmine-menu jasmine-bar jasmine-spec-list', [ + this.#add('jasmine-menu jasmine-bar jasmine-spec-list', [ createDom('span', {}, 'Spec List | '), failuresLink ]); - this.add('jasmine-menu jasmine-bar jasmine-failure-list', [ + this.#add('jasmine-menu jasmine-bar jasmine-failure-list', [ specListLink, createDom('span', {}, ' | Failures ') ]); } addGlobalFailure(failure) { - this.add(errorBarClassName, this.#globalFailureMessage(failure)); + this.#add(errorBarClassName, this.#globalFailureMessage(failure)); } addSeedBar(doneResult, stateBuilder, order) { @@ -516,7 +516,7 @@ jasmineRequire.AlertsView = function(j$) { ); } - this.add(statusBarClassName, [statusBarMessage, seedBar]); + this.#add(statusBarClassName, [statusBarMessage, seedBar]); } #globalFailureMessage(failure) { @@ -562,11 +562,10 @@ jasmineRequire.AlertsView = function(j$) { children.push(this.#createExpander(dw.stack)); } - this.add('jasmine-bar jasmine-warning', children); + this.#add('jasmine-bar jasmine-warning', children); } - // TODO private? - add(className, children) { + #add(className, children) { this.rootEl.appendChild(createDom('span', { className }, children)); } diff --git a/src/html/AlertsView.js b/src/html/AlertsView.js index 1456be87..530f43d7 100644 --- a/src/html/AlertsView.js +++ b/src/html/AlertsView.js @@ -14,11 +14,11 @@ jasmineRequire.AlertsView = function(j$) { } addDuration(ms) { - this.add('jasmine-duration', 'finished in ' + ms / 1000 + 's'); + this.#add('jasmine-duration', 'finished in ' + ms / 1000 + 's'); } addSkipped(numExecuted, numDefined) { - this.add( + this.#add( 'jasmine-bar jasmine-skipped', createDom( 'a', @@ -50,18 +50,18 @@ jasmineRequire.AlertsView = function(j$) { return false; }; - this.add('jasmine-menu jasmine-bar jasmine-spec-list', [ + this.#add('jasmine-menu jasmine-bar jasmine-spec-list', [ createDom('span', {}, 'Spec List | '), failuresLink ]); - this.add('jasmine-menu jasmine-bar jasmine-failure-list', [ + this.#add('jasmine-menu jasmine-bar jasmine-failure-list', [ specListLink, createDom('span', {}, ' | Failures ') ]); } addGlobalFailure(failure) { - this.add(errorBarClassName, this.#globalFailureMessage(failure)); + this.#add(errorBarClassName, this.#globalFailureMessage(failure)); } addSeedBar(doneResult, stateBuilder, order) { @@ -112,7 +112,7 @@ jasmineRequire.AlertsView = function(j$) { ); } - this.add(statusBarClassName, [statusBarMessage, seedBar]); + this.#add(statusBarClassName, [statusBarMessage, seedBar]); } #globalFailureMessage(failure) { @@ -158,11 +158,10 @@ jasmineRequire.AlertsView = function(j$) { children.push(this.#createExpander(dw.stack)); } - this.add('jasmine-bar jasmine-warning', children); + this.#add('jasmine-bar jasmine-warning', children); } - // TODO private? - add(className, children) { + #add(className, children) { this.rootEl.appendChild(createDom('span', { className }, children)); }