admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'issue-1854-asyncerror' of https://github.com/AndreWillomitzer/jasmine into main

Browse Source 
* Improves error message when an async expectation occurs after the spec
  finishes
* Merges #1937 from @AndreWillomitzer
* Fixes #1854
This commit is contained in:
Steve Gravrock
2021-10-12 17:13:20 -07:00
parent 469b557828 bb9175cb66
commit 503a7409f0
3 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/jasmine-core/jasmine.js
View File

@@ -1558,7 +1558,9 @@ getJasmineRequireObj().Env = function(j$) {
} }
delayedExpectationResult.message += delayedExpectationResult.message +=
'Did you forget to return or await the result of expectAsync?'; '1. Did you forget to return or await the result of expectAsync?\n' +
'2. Was done() invoked before an async operation completed?\n' +
'3. Did an expectation follow a call to done()?';
topSuite.result.failedExpectations.push(delayedExpectationResult); topSuite.result.failedExpectations.push(delayedExpectationResult);
} }

12
spec/core/integration/EnvSpec.js
View File

@@ -2932,7 +2932,9 @@ describe('Env integration', function() {
message: message:
'Spec "a suite does not wait" ran a "toBeResolved" expectation ' + 'Spec "a suite does not wait" ran a "toBeResolved" expectation ' +
'after it finished.\n' + 'after it finished.\n' +
'Did you forget to return or await the result of expectAsync?', '1. Did you forget to return or await the result of expectAsync?\n' +
'2. Was done() invoked before an async operation completed?\n' +
'3. Did an expectation follow a call to done()?',
matcherName: 'toBeResolved' matcherName: 'toBeResolved'
}), }),
jasmine.objectContaining({ jasmine.objectContaining({
@@ -2943,7 +2945,9 @@ describe('Env integration', function() {
'after it finished.\n' + 'after it finished.\n' +
"Message: \"Expected a promise to be resolved to 'something else' " + "Message: \"Expected a promise to be resolved to 'something else' " +
'but it was resolved to undefined."\n' + 'but it was resolved to undefined."\n' +
'Did you forget to return or await the result of expectAsync?', '1. Did you forget to return or await the result of expectAsync?\n' +
'2. Was done() invoked before an async operation completed?\n' +
'3. Did an expectation follow a call to done()?',
matcherName: 'toBeResolvedTo' matcherName: 'toBeResolvedTo'
}) })
]); ]);
@@ -2996,7 +3000,9 @@ describe('Env integration', function() {
message: message:
'Suite "a suite" ran a "toBeResolved" expectation ' + 'Suite "a suite" ran a "toBeResolved" expectation ' +
'after it finished.\n' + 'after it finished.\n' +
'Did you forget to return or await the result of expectAsync?', '1. Did you forget to return or await the result of expectAsync?\n' +
'2. Was done() invoked before an async operation completed?\n' +
'3. Did an expectation follow a call to done()?',
matcherName: 'toBeResolved' matcherName: 'toBeResolved'
}) })
]); ]);

4
src/core/Env.js
View File

@@ -442,7 +442,9 @@ getJasmineRequireObj().Env = function(j$) {
} }
delayedExpectationResult.message += delayedExpectationResult.message +=
'Did you forget to return or await the result of expectAsync?'; '1. Did you forget to return or await the result of expectAsync?\n' +
'2. Was done() invoked before an async operation completed?\n' +
'3. Did an expectation follow a call to done()?';
topSuite.result.failedExpectations.push(delayedExpectationResult); topSuite.result.failedExpectations.push(delayedExpectationResult);
} }