From 5eb42d67a764a763cb68465e17655b3286031dea Mon Sep 17 00:00:00 2001
From: Steve Gravrock <sdg@panix.com>
Date: Thu, 2 Dec 2021 12:12:59 -0800
Subject: [PATCH] Added a note about async testing style to contributing guide

---
 .github/CONTRIBUTING.md | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index 271dae5b..573b8866 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -97,7 +97,12 @@ Or, How to make a successful pull request
   without test-driving it.
 * _Write code in the style of the rest of the repo_ - Jasmine should look like
   a cohesive whole.
-  * **Exception**: Prefer `const` or `let` over `var`.
+  
+  **Key exceptions:**
+  * Use `const` or `let` for new variable declarations, even if nearby code
+    uses `var`.
+  * New async specs should usually be async/await or promise-returning, not
+    callback based.
 * _Ensure the *entire* test suite is green_ in all the big browsers, Node, and
   ESLint. Your contribution shouldn't break Jasmine for other users.