Fixed future deprecations

This commit is contained in:
Steve Gravrock
2020-08-02 12:57:28 -07:00
parent b0d949e0d5
commit 6b9739030d
4 changed files with 22 additions and 14 deletions

View File

@@ -5829,18 +5829,18 @@ getJasmineRequireObj().toHaveBeenCalledOnceWith = function (j$) {
expectedArgs = args.slice(1); expectedArgs = args.slice(1);
if (!j$.isSpy(actual)) { if (!j$.isSpy(actual)) {
throw new Error(getErrorMsg('Expected a spy, but got ' + j$.pp(actual) + '.')); throw new Error(getErrorMsg('Expected a spy, but got ' + util.pp(actual) + '.'));
} }
var prettyPrintedCalls = actual.calls.allArgs().map(function (argsForCall) { var prettyPrintedCalls = actual.calls.allArgs().map(function (argsForCall) {
return ' ' + j$.pp(argsForCall); return ' ' + util.pp(argsForCall);
}); });
if (actual.calls.count() === 1 && util.contains(actual.calls.allArgs(), expectedArgs)) { if (actual.calls.count() === 1 && util.contains(actual.calls.allArgs(), expectedArgs)) {
return { return {
pass: true, pass: true,
message: 'Expected spy ' + actual.and.identity + ' to have been called 0 times, multiple times, or once, but with arguments different from:\n' message: 'Expected spy ' + actual.and.identity + ' to have been called 0 times, multiple times, or once, but with arguments different from:\n'
+ ' ' + j$.pp(expectedArgs) + '\n' + ' ' + util.pp(expectedArgs) + '\n'
+ 'But the actual call was:\n' + 'But the actual call was:\n'
+ prettyPrintedCalls.join(',\n') + '.\n\n' + prettyPrintedCalls.join(',\n') + '.\n\n'
}; };
@@ -5868,7 +5868,7 @@ getJasmineRequireObj().toHaveBeenCalledOnceWith = function (j$) {
return { return {
pass: false, pass: false,
message: 'Expected spy ' + actual.and.identity + ' to have been called only once, and with given args:\n' message: 'Expected spy ' + actual.and.identity + ' to have been called only once, and with given args:\n'
+ ' ' + j$.pp(expectedArgs) + '\n' + ' ' + util.pp(expectedArgs) + '\n'
+ butString() + butString()
}; };
} }

View File

@@ -1992,6 +1992,7 @@ describe("Env integration", function() {
exception; exception;
env.describe("a suite", function () { env.describe("a suite", function () {
env.it('a spec');
try { try {
env.setSpecProperty('a prop', 'val'); env.setSpecProperty('a prop', 'val');
} catch(e) { } catch(e) {

View File

@@ -1,7 +1,8 @@
describe("toHaveBeenCalledOnceWith", function () { describe("toHaveBeenCalledOnceWith", function () {
it("passes when the actual was called only once and with matching parameters", function () { it("passes when the actual was called only once and with matching parameters", function () {
var util = jasmineUnderTest.matchersUtil, var pp = jasmineUnderTest.makePrettyPrinter(),
util = new jasmineUnderTest.MatchersUtil({ pp: pp }),
matcher = jasmineUnderTest.matchers.toHaveBeenCalledOnceWith(util), matcher = jasmineUnderTest.matchers.toHaveBeenCalledOnceWith(util),
calledSpy = new jasmineUnderTest.Spy('called-spy'), calledSpy = new jasmineUnderTest.Spy('called-spy'),
result; result;
@@ -27,7 +28,8 @@ describe("toHaveBeenCalledOnceWith", function () {
}); });
it("fails when the actual was never called", function () { it("fails when the actual was never called", function () {
var util = jasmineUnderTest.matchersUtil, var pp = jasmineUnderTest.makePrettyPrinter(),
util = new jasmineUnderTest.MatchersUtil({ pp: pp }),
matcher = jasmineUnderTest.matchers.toHaveBeenCalledOnceWith(util), matcher = jasmineUnderTest.matchers.toHaveBeenCalledOnceWith(util),
calledSpy = new jasmineUnderTest.Spy('called-spy'), calledSpy = new jasmineUnderTest.Spy('called-spy'),
result; result;
@@ -39,7 +41,8 @@ describe("toHaveBeenCalledOnceWith", function () {
}); });
it("fails when the actual was called once with different parameters", function () { it("fails when the actual was called once with different parameters", function () {
var util = jasmineUnderTest.matchersUtil, var pp = jasmineUnderTest.makePrettyPrinter(),
util = new jasmineUnderTest.MatchersUtil({ pp: pp }),
matcher = jasmineUnderTest.matchers.toHaveBeenCalledOnceWith(util), matcher = jasmineUnderTest.matchers.toHaveBeenCalledOnceWith(util),
calledSpy = new jasmineUnderTest.Spy('called-spy'), calledSpy = new jasmineUnderTest.Spy('called-spy'),
result; result;
@@ -52,7 +55,8 @@ describe("toHaveBeenCalledOnceWith", function () {
}); });
it("fails when the actual was called multiple times with expected parameters", function () { it("fails when the actual was called multiple times with expected parameters", function () {
var util = jasmineUnderTest.matchersUtil, var pp = jasmineUnderTest.makePrettyPrinter(),
util = new jasmineUnderTest.MatchersUtil({ pp: pp }),
matcher = jasmineUnderTest.matchers.toHaveBeenCalledOnceWith(util), matcher = jasmineUnderTest.matchers.toHaveBeenCalledOnceWith(util),
calledSpy = new jasmineUnderTest.Spy('called-spy'), calledSpy = new jasmineUnderTest.Spy('called-spy'),
result; result;
@@ -66,7 +70,8 @@ describe("toHaveBeenCalledOnceWith", function () {
}); });
it("fails when the actual was called multiple times (one of them - with expected parameters)", function () { it("fails when the actual was called multiple times (one of them - with expected parameters)", function () {
var util = jasmineUnderTest.matchersUtil, var pp = jasmineUnderTest.makePrettyPrinter(),
util = new jasmineUnderTest.MatchersUtil({ pp: pp }),
matcher = jasmineUnderTest.matchers.toHaveBeenCalledOnceWith(util), matcher = jasmineUnderTest.matchers.toHaveBeenCalledOnceWith(util),
calledSpy = new jasmineUnderTest.Spy('called-spy'), calledSpy = new jasmineUnderTest.Spy('called-spy'),
result; result;
@@ -80,7 +85,9 @@ describe("toHaveBeenCalledOnceWith", function () {
}); });
it("throws an exception when the actual is not a spy", function () { it("throws an exception when the actual is not a spy", function () {
var matcher = jasmineUnderTest.matchers.toHaveBeenCalledOnceWith(), var pp = jasmineUnderTest.makePrettyPrinter(),
util = new jasmineUnderTest.MatchersUtil({ pp: pp }),
matcher = jasmineUnderTest.matchers.toHaveBeenCalledOnceWith(util),
fn = function () { }; fn = function () { };
expect(function () { matcher.compare(fn) }).toThrowError(/Expected a spy, but got Function./); expect(function () { matcher.compare(fn) }).toThrowError(/Expected a spy, but got Function./);

View File

@@ -19,18 +19,18 @@ getJasmineRequireObj().toHaveBeenCalledOnceWith = function (j$) {
expectedArgs = args.slice(1); expectedArgs = args.slice(1);
if (!j$.isSpy(actual)) { if (!j$.isSpy(actual)) {
throw new Error(getErrorMsg('Expected a spy, but got ' + j$.pp(actual) + '.')); throw new Error(getErrorMsg('Expected a spy, but got ' + util.pp(actual) + '.'));
} }
var prettyPrintedCalls = actual.calls.allArgs().map(function (argsForCall) { var prettyPrintedCalls = actual.calls.allArgs().map(function (argsForCall) {
return ' ' + j$.pp(argsForCall); return ' ' + util.pp(argsForCall);
}); });
if (actual.calls.count() === 1 && util.contains(actual.calls.allArgs(), expectedArgs)) { if (actual.calls.count() === 1 && util.contains(actual.calls.allArgs(), expectedArgs)) {
return { return {
pass: true, pass: true,
message: 'Expected spy ' + actual.and.identity + ' to have been called 0 times, multiple times, or once, but with arguments different from:\n' message: 'Expected spy ' + actual.and.identity + ' to have been called 0 times, multiple times, or once, but with arguments different from:\n'
+ ' ' + j$.pp(expectedArgs) + '\n' + ' ' + util.pp(expectedArgs) + '\n'
+ 'But the actual call was:\n' + 'But the actual call was:\n'
+ prettyPrintedCalls.join(',\n') + '.\n\n' + prettyPrintedCalls.join(',\n') + '.\n\n'
}; };
@@ -58,7 +58,7 @@ getJasmineRequireObj().toHaveBeenCalledOnceWith = function (j$) {
return { return {
pass: false, pass: false,
message: 'Expected spy ' + actual.and.identity + ' to have been called only once, and with given args:\n' message: 'Expected spy ' + actual.and.identity + ' to have been called only once, and with given args:\n'
+ ' ' + j$.pp(expectedArgs) + '\n' + ' ' + util.pp(expectedArgs) + '\n'
+ butString() + butString()
}; };
} }