Deprecate non-Error arguments passed to done()

[Finishes #178267600]
2021-07-24 09:18:24 -07:00
parent 10601f5af6
commit 70d49e5b57
7 changed files with 147 additions and 36 deletions
--- a/src/core/Spec.js
+++ b/src/core/Spec.js
@@ -129,10 +129,11 @@ getJasmineRequireObj().Spec = function(j$) {
        self.onException.apply(self, arguments);
      },
      onComplete: function() {
-        onComplete(
-          self.result.status === 'failed' &&
-            new j$.StopExecutionError('spec failed')
-        );
+        if (self.result.status === 'failed') {
+          onComplete(new j$.StopExecutionError('spec failed'));
+        } else {
+          onComplete();
+        }
      },
      userContext: this.userContext()
    };