admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't report a deprecation when a runnable uses two forms of async

Browse Source 
This was made into an error in 4.0, so the deprecation is redundant
(and broken).
This commit is contained in:
Steve Gravrock
2022-05-14 11:21:40 -07:00
parent 751cf6ab5b
commit 774c83a36e
2 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/jasmine-core/jasmine.js
View File

@@ -8138,8 +8138,6 @@ getJasmineRequireObj().QueueRunner = function(j$) {
}; };
QueueRunner.prototype.diagnoseConflictingAsync_ = function(fn, retval) { QueueRunner.prototype.diagnoseConflictingAsync_ = function(fn, retval) {
var msg;
if (retval && j$.isFunction_(retval.then)) { if (retval && j$.isFunction_(retval.then)) {
// Issue a warning that matches the user's code. // Issue a warning that matches the user's code.
// Omit the stack trace because there's almost certainly no user code // Omit the stack trace because there's almost certainly no user code
@@ -8159,8 +8157,6 @@ getJasmineRequireObj().QueueRunner = function(j$) {
'function to not return a promise.' 'function to not return a promise.'
); );
} }
this.deprecated(msg, { omitStackTrace: true });
} }
}; };

4
src/core/QueueRunner.js
View File

@@ -253,8 +253,6 @@ getJasmineRequireObj().QueueRunner = function(j$) {
}; };
QueueRunner.prototype.diagnoseConflictingAsync_ = function(fn, retval) { QueueRunner.prototype.diagnoseConflictingAsync_ = function(fn, retval) {
var msg;
if (retval && j$.isFunction_(retval.then)) { if (retval && j$.isFunction_(retval.then)) {
// Issue a warning that matches the user's code. // Issue a warning that matches the user's code.
// Omit the stack trace because there's almost certainly no user code // Omit the stack trace because there's almost certainly no user code
@@ -274,8 +272,6 @@ getJasmineRequireObj().QueueRunner = function(j$) {
'function to not return a promise.' 'function to not return a promise.'
); );
} }
this.deprecated(msg, { omitStackTrace: true });
} }
}; };