Rename j$ to jasmineUnderTest for specs

- Clarifies what it is for when writing tests
- No longer named the same as the `jasmine` that is injected into live
  code
This commit is contained in:
Gregg Van Hove
2015-12-03 17:23:32 -08:00
parent a95c2cfe3f
commit 79206ccff5
60 changed files with 702 additions and 896 deletions

View File

@@ -1,10 +1,10 @@
describe("New HtmlReporter", function() {
// TODO: Figure out why this isn't rendering...
it("builds the initial DOM elements, including the title banner", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() { return container; },
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -29,14 +29,14 @@ describe("New HtmlReporter", function() {
var version = banner.querySelector(".jasmine-version"),
versionText = 'textContent' in version ? version.textContent : version.innerText;
expect(versionText).toEqual(j$.version);
expect(versionText).toEqual(jasmineUnderTest.version);
});
it("builds a single reporter even if initialized multiple times", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() { return container; },
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -52,7 +52,7 @@ describe("New HtmlReporter", function() {
it("starts the timer when jasmine begins", function() {
var env = new jasmine.Env(),
startTimerSpy = jasmine.createSpy("start-timer-spy"),
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
createElement: function() { return document.createElement.apply(document, arguments); },
timer: { start: startTimerSpy }
@@ -69,10 +69,10 @@ describe("New HtmlReporter", function() {
console = { error: function(){} };
}
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement('div'),
getContainer = function() {return container;},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -95,10 +95,10 @@ describe("New HtmlReporter", function() {
});
it("reports the status symbol of a disabled spec", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() { return container; },
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -115,10 +115,10 @@ describe("New HtmlReporter", function() {
});
it("reports the status symbol of a pending spec", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() { return container; },
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -134,10 +134,10 @@ describe("New HtmlReporter", function() {
});
it("reports the status symbol of a passing spec", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() { return container; },
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -154,10 +154,10 @@ describe("New HtmlReporter", function() {
});
it("reports the status symbol of a failing spec", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() { return container; },
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -181,10 +181,10 @@ describe("New HtmlReporter", function() {
describe("when there are suite failures", function () {
it("displays the exceptions in their own alert bars", function(){
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() { return container; },
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -212,10 +212,10 @@ describe("New HtmlReporter", function() {
if (!window.console) {
window.console = { error: function(){} };
}
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement('div'),
getContainer = function() {return container;},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -247,11 +247,11 @@ describe("New HtmlReporter", function() {
});
it("reports the run time", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
timer = jasmine.createSpyObj('timer', ['start', 'elapsed']),
getContainer = function() { return container; },
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -271,10 +271,10 @@ describe("New HtmlReporter", function() {
});
it("reports the suite and spec names with status", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() { return container; },
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -365,12 +365,12 @@ describe("New HtmlReporter", function() {
});
it("has an options menu", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() {
return container;
},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() {
@@ -400,12 +400,12 @@ describe("New HtmlReporter", function() {
describe("UI for raising/catching exceptions", function() {
it("should be unchecked if the env is catching", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() {
return container;
},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() {
@@ -424,12 +424,12 @@ describe("New HtmlReporter", function() {
});
it("should be checked if the env is not catching", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() {
return container;
},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() {
@@ -449,13 +449,13 @@ describe("New HtmlReporter", function() {
});
it("should affect the query param for catching exceptions", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
exceptionsClickHandler = jasmine.createSpy("raise exceptions checked"),
getContainer = function() {
return container;
},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
onRaiseExceptionsClick: exceptionsClickHandler,
@@ -478,12 +478,12 @@ describe("New HtmlReporter", function() {
describe("UI for throwing errors on expectation failures", function() {
it("should be unchecked if not throwing", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() {
return container;
},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() {
@@ -502,12 +502,12 @@ describe("New HtmlReporter", function() {
});
it("should be checked if throwing", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() {
return container;
},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() {
@@ -528,13 +528,13 @@ describe("New HtmlReporter", function() {
});
it("should affect the query param for throw expectation failures", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
throwingExceptionHandler = jasmine.createSpy('throwingExceptions'),
getContainer = function() {
return container;
},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
onThrowExpectationsClick: throwingExceptionHandler,
@@ -558,12 +558,12 @@ describe("New HtmlReporter", function() {
describe("UI for running tests in random order", function() {
it("should be unchecked if not randomizing", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() {
return container;
},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() {
@@ -582,12 +582,12 @@ describe("New HtmlReporter", function() {
});
it("should be checked if randomizing", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() {
return container;
},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() {
@@ -607,13 +607,13 @@ describe("New HtmlReporter", function() {
});
it("should affect the query param for random tests", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
randomHandler = jasmine.createSpy('randomHandler'),
getContainer = function() {
return container;
},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
onRandomClick: randomHandler,
@@ -635,12 +635,12 @@ describe("New HtmlReporter", function() {
});
it("should show the seed bar if randomizing", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() {
return container;
},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() {
@@ -667,12 +667,12 @@ describe("New HtmlReporter", function() {
});
it("should not show the current seed bar if not randomizing", function() {
var env = new j$.Env(),
var env = new jasmineUnderTest.Env(),
container = document.createElement("div"),
getContainer = function() {
return container;
},
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() {
@@ -694,10 +694,10 @@ describe("New HtmlReporter", function() {
it("shows a message if no specs are run", function(){
var env, container, reporter;
env = new j$.Env();
env = new jasmineUnderTest.Env();
container = document.createElement("div");
var getContainer = function() { return container; },
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -716,10 +716,10 @@ describe("New HtmlReporter", function() {
describe("and all specs pass", function() {
var env, container, reporter;
beforeEach(function() {
env = new j$.Env();
env = new jasmineUnderTest.Env();
container = document.createElement("div");
var getContainer = function() { return container; },
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -771,10 +771,10 @@ describe("New HtmlReporter", function() {
describe("and there are pending specs", function() {
var env, container, reporter;
beforeEach(function() {
env = new j$.Env();
env = new jasmineUnderTest.Env();
container = document.createElement("div");
var getContainer = function() { return container; };
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },
@@ -820,10 +820,10 @@ describe("New HtmlReporter", function() {
var env, container, reporter;
beforeEach(function() {
env = new j$.Env();
env = new jasmineUnderTest.Env();
container = document.createElement("div");
var getContainer = function() { return container; }
reporter = new j$.HtmlReporter({
reporter = new jasmineUnderTest.HtmlReporter({
env: env,
getContainer: getContainer,
createElement: function() { return document.createElement.apply(document, arguments); },

View File

@@ -1,14 +1,14 @@
describe("j$.HtmlSpecFilter", function() {
describe("jasmineUnderTest.HtmlSpecFilter", function() {
it("should match when no string is provided", function() {
var specFilter = new j$.HtmlSpecFilter();
var specFilter = new jasmineUnderTest.HtmlSpecFilter();
expect(specFilter.matches("foo")).toBe(true);
expect(specFilter.matches("*bar")).toBe(true);
});
it("should only match the provided string", function() {
var specFilter = new j$.HtmlSpecFilter({
var specFilter = new jasmineUnderTest.HtmlSpecFilter({
filterString: function() { return "foo"; }
});

View File

@@ -2,7 +2,7 @@ describe("MatchersSpec - HTML Dependent", function () {
var env, spec;
beforeEach(function() {
env = new j$.Env();
env = new jasmineUnderTest.Env();
var suite = env.describe("suite", function() {
spec = env.it("spec", function() {

View File

@@ -1,15 +1,15 @@
describe("j$.pp (HTML Dependent)", function () {
describe("jasmineUnderTest.pp (HTML Dependent)", function () {
it("should stringify HTML nodes properly", function() {
var sampleNode = document.createElement('div');
sampleNode.innerHTML = 'foo<b>bar</b>';
expect(j$.pp(sampleNode)).toEqual("HTMLNode");
expect(j$.pp({foo: sampleNode})).toEqual("Object({ foo: HTMLNode })");
expect(jasmineUnderTest.pp(sampleNode)).toEqual("HTMLNode");
expect(jasmineUnderTest.pp({foo: sampleNode})).toEqual("Object({ foo: HTMLNode })");
});
it("should print Firefox's wrapped native objects correctly", function() {
if(jasmine.getEnv().firefoxVersion) {
try { new CustomEvent(); } catch(e) { var err = e; };
expect(j$.pp(err)).toMatch(/Not enough arguments/);
expect(jasmineUnderTest.pp(err)).toMatch(/Not enough arguments/);
}
});
});

View File

@@ -5,7 +5,7 @@ describe("QueryString", function() {
var windowLocation = {
search: ""
},
queryString = new j$.QueryString({
queryString = new jasmineUnderTest.QueryString({
getWindowLocation: function() { return windowLocation }
});
@@ -18,7 +18,7 @@ describe("QueryString", function() {
var windowLocation = {
search: "?foo=bar"
},
queryString = new j$.QueryString({
queryString = new jasmineUnderTest.QueryString({
getWindowLocation: function() { return windowLocation }
});
@@ -34,7 +34,7 @@ describe("QueryString", function() {
var windowLocation = {
search: "?foo=bar"
},
queryString = new j$.QueryString({
queryString = new jasmineUnderTest.QueryString({
getWindowLocation: function() { return windowLocation }
});
@@ -51,7 +51,7 @@ describe("QueryString", function() {
var windowLocation = {
search: "?baz=quux%20corge"
},
queryString = new j$.QueryString({
queryString = new jasmineUnderTest.QueryString({
getWindowLocation: function() { return windowLocation }
});
@@ -62,7 +62,7 @@ describe("QueryString", function() {
var windowLocation = {
search: ""
},
queryString = new j$.QueryString({
queryString = new jasmineUnderTest.QueryString({
getWindowLocation: function() { return windowLocation }
});

View File

@@ -4,7 +4,7 @@ describe("ResultsNode", function() {
id: 123,
message: "foo"
},
node = new j$.ResultsNode(fakeResult, "suite", null);
node = new jasmineUnderTest.ResultsNode(fakeResult, "suite", null);
expect(node.result).toBe(fakeResult);
expect(node.type).toEqual("suite");
@@ -19,7 +19,7 @@ describe("ResultsNode", function() {
id: 456,
message: "bar"
},
node = new j$.ResultsNode(fakeResult, "suite", null);
node = new jasmineUnderTest.ResultsNode(fakeResult, "suite", null);
node.addChild(fakeChildResult, "spec");
@@ -37,7 +37,7 @@ describe("ResultsNode", function() {
id: 456,
message: "bar"
},
node = new j$.ResultsNode(fakeResult, "suite", null);
node = new jasmineUnderTest.ResultsNode(fakeResult, "suite", null);
node.addChild(fakeChildResult, "spec");
@@ -53,7 +53,7 @@ describe("ResultsNode", function() {
id: 456,
message: "bar"
},
node = new j$.ResultsNode(fakeResult, "suite", null);
node = new jasmineUnderTest.ResultsNode(fakeResult, "suite", null);
node.addChild(fakeChildResult, "spec");