From 394be998329e2d76f8edc9ab20fd621495e91aec Mon Sep 17 00:00:00 2001 From: Steve Gravrock Date: Fri, 3 Sep 2021 15:51:51 -0700 Subject: [PATCH 1/3] Fixed sass deprecation warnings See . [#179260511] --- src/html/_HTMLReporter.scss | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/html/_HTMLReporter.scss b/src/html/_HTMLReporter.scss index 2b128a04..2ee9c9be 100644 --- a/src/html/_HTMLReporter.scss +++ b/src/html/_HTMLReporter.scss @@ -1,3 +1,5 @@ +@use "sass:math"; + $line-height: 14px; $margin-unit: 14px; @@ -117,7 +119,7 @@ body { li { display: inline-block; - height: ($line-height / 2) + 3; + height: math.div($line-height, 2) + 3; width: $line-height; font-size: 16px; @@ -132,7 +134,7 @@ body { } &.jasmine-failed { - line-height: ($line-height / 2) + 2; + line-height: math.div($line-height, 2) + 2; &:before { color: $failing-color; @@ -282,8 +284,8 @@ body { padding-left: 0; &.jasmine-suite { - margin-top: $margin-unit/2; - margin-bottom: $margin-unit/2 + margin-top: math.div($margin-unit, 2); + margin-bottom: math.div($margin-unit, 2) } } From 1c9382c9907eff62cfa95aceef180fbf7d0c8b86 Mon Sep 17 00:00:00 2001 From: Steve Gravrock Date: Sat, 4 Sep 2021 13:39:17 -0700 Subject: [PATCH 2/3] Dogfood the new jasmine-npm completion interface --- Gruntfile.js | 14 ++++++++++---- package.json | 2 +- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/Gruntfile.js b/Gruntfile.js index 14077d78..e50595cd 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -40,11 +40,17 @@ module.exports = function(grunt) { jasmine = new Jasmine({jasmineCore: jasmineCore}); jasmine.loadConfigFile('./spec/support/jasmine.json'); - jasmine.onComplete(function(passed) { - done(passed); - }); - jasmine.execute(); + jasmine.exitOnCompletion = false; + jasmine.execute().then( + result => { + done(result.overallStatus === 'passed'); + }, + err => { + console.error(err); + exit(1); + } + ); } ); diff --git a/package.json b/package.json index 84dd9372..093c77fd 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "grunt-contrib-concat": "^1.0.1", "grunt-css-url-embed": "^1.11.1", "grunt-sass": "^3.0.2", - "jasmine": "^3.4.0", + "jasmine": "github:jasmine/jasmine-npm#main", "jasmine-browser-runner": "github:jasmine/jasmine-browser#main", "jsdom": "^15.0.0", "load-grunt-tasks": "^4.0.0", From 3a47a3bd0431da2414731b908baeebf443088f0e Mon Sep 17 00:00:00 2001 From: Steve Gravrock Date: Mon, 6 Sep 2021 15:29:09 -0700 Subject: [PATCH 3/3] Fixed flaky spec --- spec/core/integration/EnvSpec.js | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/spec/core/integration/EnvSpec.js b/spec/core/integration/EnvSpec.js index 8224d3a7..b257d085 100644 --- a/spec/core/integration/EnvSpec.js +++ b/spec/core/integration/EnvSpec.js @@ -465,7 +465,7 @@ describe('Env integration', function() { var global = { setTimeout: function(fn, delay) { - setTimeout(fn, delay); + return setTimeout(fn, delay); }, clearTimeout: function(fn, delay) { clearTimeout(fn, delay); @@ -1018,7 +1018,7 @@ describe('Env integration', function() { var globalSetTimeout = jasmine .createSpy('globalSetTimeout') .and.callFake(function(cb, t) { - setTimeout(cb, t); + return setTimeout(cb, t); }), delayedFunctionForGlobalClock = jasmine.createSpy( 'delayedFunctionForGlobalClock' @@ -1033,7 +1033,7 @@ describe('Env integration', function() { setTimeout: globalSetTimeout, clearTimeout: clearTimeout, setImmediate: function(cb) { - setTimeout(cb, 0); + return setTimeout(cb, 0); } } }); @@ -1108,7 +1108,7 @@ describe('Env integration', function() { setInterval: setInterval, clearInterval: clearInterval, setImmediate: function(cb) { - realSetTimeout(cb, 0); + return realSetTimeout(cb, 0); } } }); @@ -2255,7 +2255,7 @@ describe('Env integration', function() { it('reports errors that occur during loading', function(done) { var global = { setTimeout: function(fn, delay) { - setTimeout(fn, delay); + return setTimeout(fn, delay); }, clearTimeout: function(fn, delay) { clearTimeout(fn, delay); @@ -2312,7 +2312,7 @@ describe('Env integration', function() { var originalOnerror = jasmine.createSpy('original onerror'); var global = { setTimeout: function(fn, delay) { - setTimeout(fn, delay); + return setTimeout(fn, delay); }, clearTimeout: function(fn, delay) { clearTimeout(fn, delay); @@ -2513,7 +2513,7 @@ describe('Env integration', function() { it('is "failed"', function(done) { var global = { setTimeout: function(fn, delay) { - setTimeout(fn, delay); + return setTimeout(fn, delay); }, clearTimeout: function(fn, delay) { clearTimeout(fn, delay); @@ -2835,10 +2835,6 @@ describe('Env integration', function() { }); it('provides custom equality testers to async matchers', function(done) { - if (jasmine.getEnv().skipBrowserFlake) { - jasmine.getEnv().skipBrowserFlake(); - } - jasmine.getEnv().requirePromises(); var specDone = jasmine.createSpy('specDone');