Cleanup spy promise strategies to be more consistent with Jasmine at large

- Rename `resolveWith` to `resolveTo` to match `toBeResolvedTo`
- No longer wrap non-Errors in `rejectWith`

- Fixes #1715
This commit is contained in:
Gregg Van Hove
2019-05-23 17:29:12 -07:00
parent b4cbe9850f
commit 8af669677a
4 changed files with 16 additions and 18 deletions

View File

@@ -46,12 +46,12 @@ getJasmineRequireObj().SpyStrategy = function(j$) {
/**
* Tell the spy to return a promise resolving to the specified value when invoked.
* @name SpyStrategy#resolveWith
* @name SpyStrategy#resolveTo
* @function
* @param {*} value The value to return.
*/
this.resolveWith = function(value) {
var Promise = requirePromise('resolveWith');
this.resolveTo = function(value) {
var Promise = requirePromise('resolveTo');
self.plan = function() {
return Promise.resolve(value);
};
@@ -66,10 +66,9 @@ getJasmineRequireObj().SpyStrategy = function(j$) {
*/
this.rejectWith = function(value) {
var Promise = requirePromise('rejectWith');
var error = value instanceof Error ? value : new Error(value);
self.plan = function() {
return Promise.reject(error);
return Promise.reject(value);
};
return self.getSpy();
};