Allow pending to take a reason and show it in the HtmlReporter

[#78954014] Fix #671
This commit is contained in:
slackersoft
2015-01-26 15:55:31 -08:00
parent a857f4c042
commit 8e3066db42
10 changed files with 116 additions and 16 deletions

View File

@@ -11,6 +11,12 @@ describe("Env", function() {
env.pending();
}).toThrow(j$.Spec.pendingSpecExceptionMessage);
});
it("throws the Pending Spec exception with a custom message", function() {
expect(function() {
env.pending('custom message');
}).toThrow(j$.Spec.pendingSpecExceptionMessage + 'custom message');
});
});
describe("#topSuite", function() {

View File

@@ -14,6 +14,10 @@ describe("Spec", function() {
expect(j$.Spec.isPendingSpecException(fakeError)).toBe(true);
});
it("#isPendingSpecException returns true for a pending spec exception with a custom message", function() {
expect(j$.Spec.isPendingSpecException(j$.Spec.pendingSpecExceptionMessage + 'foo')).toBe(true);
});
it("#isPendingSpecException returns false for not a pending spec exception", function() {
var e = new Error("foo");
@@ -174,7 +178,8 @@ describe("Spec", function() {
description: 'with a spec',
fullName: 'a suite with a spec',
failedExpectations: [],
passedExpectations: []
passedExpectations: [],
pendingReason: ''
});
});
@@ -254,6 +259,24 @@ describe("Spec", function() {
spec.execute();
expect(spec.status()).toEqual("pending");
expect(spec.result.pendingReason).toEqual('');
});
it("should set the pendingReason", function() {
var fakeQueueRunner = function(opts) {
opts.onException(new Error(j$.Spec.pendingSpecExceptionMessage + 'custom message'));
},
spec = new j$.Spec({
description: 'my test',
id: 'some-id',
queueableFn: { fn: function() { } },
queueRunnerFactory: fakeQueueRunner
});
spec.execute();
expect(spec.status()).toEqual("pending");
expect(spec.result.pendingReason).toEqual('custom message');
});
});
});

View File

@@ -1137,6 +1137,30 @@ describe("Env integration", function() {
env.execute();
});
it('should report pending spec messages', function(done) {
var env = new j$.Env(),
reporter = jasmine.createSpyObj('fakeReporter', [
'specDone',
'jasmineDone'
]);
reporter.jasmineDone.and.callFake(function() {
var specStatus = reporter.specDone.calls.argsFor(0)[0];
expect(specStatus.pendingReason).toBe('with a message');
done();
});
env.addReporter(reporter);
env.it('will be pending', function() {
env.pending('with a message');
});
env.execute();
});
it('should report xdescribes as expected', function(done) {
var env = new j$.Env(),
reporter = jasmine.createSpyObj('fakeReporter', [