admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(Clock): Fix throttling test unit conversion bug

Browse Source 
* fixes the throttling timeout test which incorrectly converted
from milliseconds to seconds before making an assertion expecting
milliseconds.
* reduces number of timeouts from 2000 to 100, which is still more than enough
to observe throttling (or lackthereof).
* Omits Node from the test since it does not throttle timeouts
This commit is contained in:
Andrew Scott
2025-04-07 08:32:03 -07:00
parent e5c543a0a1
commit 8f539f17b2
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
spec/core/ClockSpec.js
View File

@@ -788,23 +788,25 @@ describe('Clock (acceptance)', function() {
}); });
it('avoids throttling in browsers other than Safari', async () => { it('avoids throttling in browsers other than Safari', async () => {
if ( if (typeof navigator === 'undefined' || typeof window === 'undefined') {
typeof navigator !== 'undefined' && // Node does not throttle timeouts so this test isn't necessary
pending('This test only runs in browsers.');
} else if (
/^((?!chrome|android|firefox).)*safari/i.test(navigator.userAgent) /^((?!chrome|android|firefox).)*safari/i.test(navigator.userAgent)
) { ) {
return; pending('Timeout throttling prevention does not work in Safari.');
} }
// This test ensures the setTimeout loop isn't getting throttled by browsers // This test ensures the setTimeout loop isn't getting throttled by browsers
const promises = []; const promises = [];
// 2000 timers at ~4ms throttling = 8_000ms would time out if we weren't // 100 timers at ~4ms throttling = 400ms would time out if we weren't
// preventing the throttle with the MessageChannel trick. // preventing the throttle with the MessageChannel trick.
for (let i = 0; i < 2000; i++) { for (let i = 0; i < 100; i++) {
promises.push(new Promise(resolve => clock.setTimeout(resolve))); promises.push(new Promise(resolve => clock.setTimeout(resolve)));
} }
const startTimeMs = performance.now() / 1000; const startTimeMs = performance.now();
await Promise.all(promises); await Promise.all(promises);
const endTimeMs = performance.now() / 1000; const endTimeMs = performance.now();
expect(endTimeMs - startTimeMs).toBeLessThan(1000); expect(endTimeMs - startTimeMs).toBeLessThan(50);
}); });
it('is easy to test async functions with interleaved timers and microtasks', async () => { it('is easy to test async functions with interleaved timers and microtasks', async () => {