From 98d5284c19f61a8365fcd8fd26b421b5d0ffed05 Mon Sep 17 00:00:00 2001 From: Steve Gravrock Date: Fri, 15 Aug 2025 06:58:08 -0700 Subject: [PATCH] Check for and silence suite reentry warnings in Jasmine's own tests --- spec/core/TreeProcessorSpec.js | 2 ++ spec/core/integration/SpecRunningSpec.js | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/spec/core/TreeProcessorSpec.js b/spec/core/TreeProcessorSpec.js index b0efa681..6a1ef366 100644 --- a/spec/core/TreeProcessorSpec.js +++ b/spec/core/TreeProcessorSpec.js @@ -787,6 +787,7 @@ describe('TreeProcessor', function() { runQueue }); + spyOn(jasmineUnderTest.getEnv(), 'deprecated'); processor.execute(); const queueableFns = runQueue.calls.mostRecent().args[0].queueableFns; expect(queueableFns.length).toBe(5); @@ -831,6 +832,7 @@ describe('TreeProcessor', function() { runQueue }); + spyOn(jasmineUnderTest.getEnv(), 'deprecated'); processor.execute(); const queueableFns = runQueue.calls.mostRecent().args[0].queueableFns; expect(queueableFns.length).toBe(5); diff --git a/spec/core/integration/SpecRunningSpec.js b/spec/core/integration/SpecRunningSpec.js index a680949a..a1975876 100644 --- a/spec/core/integration/SpecRunningSpec.js +++ b/spec/core/integration/SpecRunningSpec.js @@ -621,9 +621,14 @@ describe('spec running', function() { actions.push('spec3'); }); + spyOn(jasmineUnderTest.getEnv(), 'deprecated'); + await env.execute([spec2.id, spec3.id, spec1.id]); expect(actions).toEqual(['spec2', 'spec3', 'spec1']); + expect(jasmineUnderTest.getEnv().deprecated).toHaveBeenCalledWith( + 'The specified spec/suite order splits up a suite, running unrelated specs in the middle of it. This will become an error in a future release.' + ); }); it('refuses to re-enter suites with a beforeAll', async function() {