admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Extract spec state management out of Spec#execute

Browse Source
This commit is contained in:
Steve Gravrock
2025-08-23 08:30:56 -07:00
parent 56ac8f5505
commit a980ae6bf2
2 changed files with 38 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
lib/jasmine-core/jasmine.js
View File

@@ -841,6 +841,23 @@ getJasmineRequireObj().Spec = function(j$) {
this.result.properties[key] = value; this.result.properties[key] = value;
}; };
Spec.prototype.executionStarted = function() {
this.timer.start();
};
Spec.prototype.executionFinished = function(excluded, failSpecWithNoExp) {
if (this.autoCleanClosures) {
this.queueableFn.fn = null;
}
this.result.status = this.status(excluded, failSpecWithNoExp);
this.result.duration = this.timer.elapsed();
if (this.result.status !== 'failed') {
this.result.debugLogs = null;
}
};
Spec.prototype.execute = function( Spec.prototype.execute = function(
runQueue, runQueue,
globalErrors, globalErrors,
@@ -854,23 +871,14 @@ getJasmineRequireObj().Spec = function(j$) {
) { ) {
const start = { const start = {
fn: done => { fn: done => {
this.timer.start(); this.executionStarted();
onStart(done); onStart(done);
} }
}; };
const complete = { const complete = {
fn: done => { fn: done => {
if (this.autoCleanClosures) { this.executionFinished(excluded, failSpecWithNoExp);
this.queueableFn.fn = null;
}
this.result.status = this.status(excluded, failSpecWithNoExp);
this.result.duration = this.timer.elapsed();
if (this.result.status !== 'failed') {
this.result.debugLogs = null;
}
resultCallback(this.result, done); resultCallback(this.result, done);
}, },
type: 'specCleanup' type: 'specCleanup'

30
src/core/Spec.js
View File

@@ -69,6 +69,23 @@ getJasmineRequireObj().Spec = function(j$) {
this.result.properties[key] = value; this.result.properties[key] = value;
}; };
Spec.prototype.executionStarted = function() {
this.timer.start();
};
Spec.prototype.executionFinished = function(excluded, failSpecWithNoExp) {
if (this.autoCleanClosures) {
this.queueableFn.fn = null;
}
this.result.status = this.status(excluded, failSpecWithNoExp);
this.result.duration = this.timer.elapsed();
if (this.result.status !== 'failed') {
this.result.debugLogs = null;
}
};
Spec.prototype.execute = function( Spec.prototype.execute = function(
runQueue, runQueue,
globalErrors, globalErrors,
@@ -82,23 +99,14 @@ getJasmineRequireObj().Spec = function(j$) {
) { ) {
const start = { const start = {
fn: done => { fn: done => {
this.timer.start(); this.executionStarted();
onStart(done); onStart(done);
} }
}; };
const complete = { const complete = {
fn: done => { fn: done => {
if (this.autoCleanClosures) { this.executionFinished(excluded, failSpecWithNoExp);
this.queueableFn.fn = null;
}
this.result.status = this.status(excluded, failSpecWithNoExp);
this.result.duration = this.timer.elapsed();
if (this.result.status !== 'failed') {
this.result.debugLogs = null;
}
resultCallback(this.result, done); resultCallback(this.result, done);
}, },
type: 'specCleanup' type: 'specCleanup'