admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use default failure message for toBeNaN

Browse Source 
It is providing the same functionality by default without a custom error message
This commit is contained in:
Sheel Choksi
2014-02-17 22:45:54 -08:00
parent 4ddf316388
commit b6c03a34e7
2 changed files with 1 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/core/matchers/toBeNaNSpec.js
View File

@@ -1,11 +1,10 @@
describe("toBeNaN", function() { describe("toBeNaN", function() {
it("passes for NaN with a custom .not fail", function() { it("passes for NaN", function() {
var matcher = j$.matchers.toBeNaN(), var matcher = j$.matchers.toBeNaN(),
result; result;
result = matcher.compare(Number.NaN); result = matcher.compare(Number.NaN);
expect(result.pass).toBe(true); expect(result.pass).toBe(true);
expect(result.message).toEqual("Expected actual not to be NaN.");
}); });
it("fails for anything not a NaN", function() { it("fails for anything not a NaN", function() {
@@ -27,11 +26,4 @@ describe("toBeNaN", function() {
result = matcher.compare(Number.POSITIVE_INFINITY); result = matcher.compare(Number.POSITIVE_INFINITY);
expect(result.pass).toBe(false); expect(result.pass).toBe(false);
}); });
it("has a custom message on failure", function() {
var matcher = j$.matchers.toBeNaN(),
result = matcher.compare(0);
expect(result.message).toEqual("Expected 0 to be NaN.");
});
}); });

6
src/core/matchers/toBeNaN.js
View File

@@ -7,12 +7,6 @@ getJasmineRequireObj().toBeNaN = function(j$) {
pass: (actual !== actual) pass: (actual !== actual)
}; };
if (result.pass) {
result.message = "Expected actual not to be NaN.";
} else {
result.message = "Expected " + j$.pp(actual) + " to be NaN.";
}
return result; return result;
} }
}; };