admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clarified deprecation message for this in describes

Browse Source
This commit is contained in:
Steve Gravrock
2021-10-12 15:40:13 -07:00
parent 8cadfbd829
commit c1db8f2f82
3 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/jasmine-core/jasmine.js
View File

@@ -4219,7 +4219,9 @@ getJasmineRequireObj().deprecatingSuiteProxy = function(j$) {
/* eslint-disable compat/compat */ /* eslint-disable compat/compat */
// TODO: Remove this in the next major release. // TODO: Remove this in the next major release.
getJasmineRequireObj().deprecatingThisProxy = function(j$) { getJasmineRequireObj().deprecatingThisProxy = function(j$) {
var msg = "Access to 'this' in describe functions is deprecated."; var msg =
"Access to 'this' in describe functions (and in arrow functions " +
'inside describe functions) is deprecated.';
try { try {
new Proxy({}, {}); new Proxy({}, {});

4
spec/core/EnvSpec.js
View File

@@ -768,7 +768,9 @@ describe('Env', function() {
it("deprecates access to 'this' in describes", function() { it("deprecates access to 'this' in describes", function() {
jasmine.getEnv().requireProxy(); jasmine.getEnv().requireProxy();
var msg = "Access to 'this' in describe functions is deprecated.", var msg =
"Access to 'this' in describe functions (and in arrow " +
'functions inside describe functions) is deprecated.',
ran = false; ran = false;
spyOn(env, 'deprecated'); spyOn(env, 'deprecated');

4
src/core/deprecatingThisProxy.js
View File

@@ -1,7 +1,9 @@
/* eslint-disable compat/compat */ /* eslint-disable compat/compat */
// TODO: Remove this in the next major release. // TODO: Remove this in the next major release.
getJasmineRequireObj().deprecatingThisProxy = function(j$) { getJasmineRequireObj().deprecatingThisProxy = function(j$) {
var msg = "Access to 'this' in describe functions is deprecated."; var msg =
"Access to 'this' in describe functions (and in arrow functions " +
'inside describe functions) is deprecated.';
try { try {
new Proxy({}, {}); new Proxy({}, {});