From c3960c4a96e5a4ee3a7eb40c0151a8b9598839eb Mon Sep 17 00:00:00 2001 From: Steve Gravrock Date: Tue, 18 Jun 2024 18:13:11 -0700 Subject: [PATCH] Test against Node 22 --- .circleci/config.yml | 17 +++++++++++++++++ README.md | 2 +- spec/core/baseSpec.js | 5 ++++- 3 files changed, 22 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 04acbcb3..df511e8e 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -4,6 +4,10 @@ version: 2.1 executors: + node22: + docker: + - image: cimg/node:22.0.0 + working_directory: ~/workspace node20: docker: - image: cimg/node:20.0.0 @@ -94,12 +98,20 @@ workflows: push: jobs: + - build: + executor: node22 + name: build_node_22 - build: executor: node20 name: build_node_20 - build: executor: node18 name: build_node_18 + - test_node: + executor: node22 + name: test_node_22 + requires: + - build_node_22 - test_node: executor: node20 name: test_node_20 @@ -115,6 +127,11 @@ workflows: name: test_parallel_node_18 requires: - build_node_18 + - test_parallel: + executor: node22 + name: test_parallel_node_22 + requires: + - build_node_22 - test_parallel: executor: node20 name: test_parallel_node_20 diff --git a/README.md b/README.md index 3561ee2f..1a673075 100644 --- a/README.md +++ b/README.md @@ -29,7 +29,7 @@ Microsoft Edge) as well as Node. | Environment | Supported versions | |-------------------|---------------------| -| Node | 18, 20 | +| Node | 18, 20, 22 | | Safari | 15-17 | | Chrome | Evergreen | | Firefox | Evergreen, 102, 115 | diff --git a/spec/core/baseSpec.js b/spec/core/baseSpec.js index 8de92396..4910109e 100644 --- a/spec/core/baseSpec.js +++ b/spec/core/baseSpec.js @@ -179,7 +179,10 @@ describe('base helpers', function() { f2 = jasmine.createSpy('setTimeout callback for ' + (max + 1)); // Suppress printing of TimeoutOverflowWarning in node - spyOn(console, 'error'); + if (typeof process !== 'undefined' && process.emitWarning) { + spyOn(process, 'emitWarning'); // Node 22 + } + spyOn(console, 'error'); // Node <22 let id = setTimeout(f1, max); setTimeout(function() {