Treat multiple calls to done callbacks as errors

src/core/Suite.js

@@ -1,6 +1,5 @@
 getJasmineRequireObj().Suite = function(j$) {
   function Suite(attrs) {
-    this.env = attrs.env;
     this.id = attrs.id;
     this.parentSuite = attrs.parentSuite;
     this.description = attrs.description;
@@ -8,6 +7,7 @@ getJasmineRequireObj().Suite = function(j$) {
     this.asyncExpectationFactory = attrs.asyncExpectationFactory;
     this.expectationResultFactory = attrs.expectationResultFactory;
     this.throwOnExpectationFailure = !!attrs.throwOnExpectationFailure;
+    this.onLateError = attrs.onLateError;
 
     this.beforeFns = [];
     this.afterFns = [];
@@ -167,29 +167,25 @@ getJasmineRequireObj().Suite = function(j$) {
   };
 
   Suite.prototype.onMultipleDone = function() {
-    var msg;
+    let msg;
 
     // Issue a deprecation. Include the context ourselves and pass
     // ignoreRunnable: true, since getting here always means that we've already
     // moved on and the current runnable isn't the one that caused the problem.
     if (this.parentSuite) {
       msg =
-        "An asynchronous function called its 'done' callback more than " +
-        'once. This is a bug in the spec, beforeAll, beforeEach, afterAll, ' +
-        'or afterEach function in question. This will be treated as an error ' +
-        'in a future version.\n' +
+        "An asynchronous beforeAll or afterAll function called its 'done' " +
+        'callback more than once.\n' +
         '(in suite: ' +
         this.getFullName() +
         ')';
     } else {
       msg =
         'A top-level beforeAll or afterAll function called its ' +
-        "'done' callback more than once. This is a bug in the beforeAll " +
-        'or afterAll function in question. This will be treated as an ' +
-        'error in a future version.';
+        "'done' callback more than once.";
     }
 
-    this.env.deprecated(msg, { ignoreRunnable: true });
+    this.onLateError(new Error(msg));
   };
 
   Suite.prototype.addExpectationResult = function() {