Require curly braces around loop and conditonal bodies

This commit is contained in:
Steve Gravrock
2024-09-02 11:30:36 -07:00
parent f602c4911c
commit d0fe5c4712
8 changed files with 32 additions and 10 deletions

View File

@@ -11,6 +11,7 @@
"ecmaVersion": 2018 "ecmaVersion": 2018
}, },
"rules": { "rules": {
"curly": "error",
"quotes": [ "quotes": [
"error", "error",
"single", "single",

View File

@@ -2430,7 +2430,9 @@ getJasmineRequireObj().MapContaining = function(j$) {
} }
MapContaining.prototype.asymmetricMatch = function(other, matchersUtil) { MapContaining.prototype.asymmetricMatch = function(other, matchersUtil) {
if (!j$.isMap(other)) return false; if (!j$.isMap(other)) {
return false;
}
for (const [key, value] of this.sample) { for (const [key, value] of this.sample) {
// for each key/value pair in `sample` // for each key/value pair in `sample`
@@ -2569,7 +2571,9 @@ getJasmineRequireObj().SetContaining = function(j$) {
} }
SetContaining.prototype.asymmetricMatch = function(other, matchersUtil) { SetContaining.prototype.asymmetricMatch = function(other, matchersUtil) {
if (!j$.isSet(other)) return false; if (!j$.isSet(other)) {
return false;
}
for (const item of this.sample) { for (const item of this.sample) {
// for each item in `sample` there should be at least one matching item in `other` // for each item in `sample` there should be at least one matching item in `other`
@@ -2918,7 +2922,9 @@ getJasmineRequireObj().clearStack = function(j$) {
function getUnclampedSetTimeout(global) { function getUnclampedSetTimeout(global) {
const { setTimeout } = global; const { setTimeout } = global;
if (j$.util.isUndefined(global.MessageChannel)) return setTimeout; if (j$.util.isUndefined(global.MessageChannel)) {
return setTimeout;
}
const postMessage = getPostMessage(global); const postMessage = getPostMessage(global);
return function unclampedSetTimeout(fn) { return function unclampedSetTimeout(fn) {
@@ -6677,7 +6683,10 @@ getJasmineRequireObj().toHaveSpyInteractions = function(j$) {
let hasSpy = false; let hasSpy = false;
const calledSpies = []; const calledSpies = [];
for (const spy of Object.values(actual)) { for (const spy of Object.values(actual)) {
if (!j$.isSpy(spy)) continue; if (!j$.isSpy(spy)) {
continue;
}
hasSpy = true; hasSpy = true;
if (spy.calls.any()) { if (spy.calls.any()) {

View File

@@ -38,7 +38,9 @@ describe('ClearStack', function() {
const clearStack = jasmineUnderTest.getClearStack(global); const clearStack = jasmineUnderTest.getClearStack(global);
for (let i = 0; i < 9; i++) clearStack(function() {}); for (let i = 0; i < 9; i++) {
clearStack(function() {});
}
expect(fakeChannel.port2.postMessage).not.toHaveBeenCalled(); expect(fakeChannel.port2.postMessage).not.toHaveBeenCalled();

View File

@@ -1315,8 +1315,9 @@ describe('Env integration', function() {
'works with constructors when using callThrough spy strategy', 'works with constructors when using callThrough spy strategy',
function() { function() {
function MyClass(foo) { function MyClass(foo) {
if (!(this instanceof MyClass)) if (!(this instanceof MyClass)) {
throw new Error('You must use the new keyword.'); throw new Error('You must use the new keyword.');
}
this.foo = foo; this.foo = foo;
} }
const subject = { MyClass: MyClass }; const subject = { MyClass: MyClass };

View File

@@ -44,7 +44,9 @@ getJasmineRequireObj().clearStack = function(j$) {
function getUnclampedSetTimeout(global) { function getUnclampedSetTimeout(global) {
const { setTimeout } = global; const { setTimeout } = global;
if (j$.util.isUndefined(global.MessageChannel)) return setTimeout; if (j$.util.isUndefined(global.MessageChannel)) {
return setTimeout;
}
const postMessage = getPostMessage(global); const postMessage = getPostMessage(global);
return function unclampedSetTimeout(fn) { return function unclampedSetTimeout(fn) {

View File

@@ -11,7 +11,9 @@ getJasmineRequireObj().MapContaining = function(j$) {
} }
MapContaining.prototype.asymmetricMatch = function(other, matchersUtil) { MapContaining.prototype.asymmetricMatch = function(other, matchersUtil) {
if (!j$.isMap(other)) return false; if (!j$.isMap(other)) {
return false;
}
for (const [key, value] of this.sample) { for (const [key, value] of this.sample) {
// for each key/value pair in `sample` // for each key/value pair in `sample`

View File

@@ -11,7 +11,9 @@ getJasmineRequireObj().SetContaining = function(j$) {
} }
SetContaining.prototype.asymmetricMatch = function(other, matchersUtil) { SetContaining.prototype.asymmetricMatch = function(other, matchersUtil) {
if (!j$.isSet(other)) return false; if (!j$.isSet(other)) {
return false;
}
for (const item of this.sample) { for (const item of this.sample) {
// for each item in `sample` there should be at least one matching item in `other` // for each item in `sample` there should be at least one matching item in `other`

View File

@@ -32,7 +32,10 @@ getJasmineRequireObj().toHaveSpyInteractions = function(j$) {
let hasSpy = false; let hasSpy = false;
const calledSpies = []; const calledSpies = [];
for (const spy of Object.values(actual)) { for (const spy of Object.values(actual)) {
if (!j$.isSpy(spy)) continue; if (!j$.isSpy(spy)) {
continue;
}
hasSpy = true; hasSpy = true;
if (spy.calls.any()) { if (spy.calls.any()) {