Introduce a tab bar
This will make it easier to add a third tab to HtmlReporterV2.
This commit is contained in:
@@ -3,6 +3,9 @@ jasmineRequire.HtmlReporterV2 = function(j$) {
|
||||
|
||||
const { createDom, noExpectations } = j$.private.htmlReporterUtils;
|
||||
|
||||
const specListTabId = 'jasmine-specListTab';
|
||||
const failuresTabId = 'jasmine-failuresTab';
|
||||
|
||||
/**
|
||||
* @class HtmlReporterV2
|
||||
* @classdesc Displays results and allows re-running individual specs and suites.
|
||||
@@ -31,6 +34,7 @@ jasmineRequire.HtmlReporterV2 = function(j$) {
|
||||
// Sub-views
|
||||
#alerts;
|
||||
#statusBar;
|
||||
#tabBar;
|
||||
#progress;
|
||||
#banner;
|
||||
#failures;
|
||||
@@ -68,6 +72,22 @@ jasmineRequire.HtmlReporterV2 = function(j$) {
|
||||
this.#statusBar = new j$.private.OverallStatusBar(this.#urlBuilder);
|
||||
this.#statusBar.showRunning();
|
||||
this.#alerts.addBar(this.#statusBar.rootEl);
|
||||
|
||||
this.#tabBar = new j$.private.TabBar(
|
||||
[
|
||||
{ id: specListTabId, label: 'Spec List' },
|
||||
{ id: failuresTabId, label: 'Failures' }
|
||||
],
|
||||
tabId => {
|
||||
if (tabId === specListTabId) {
|
||||
this.#setMenuModeTo('jasmine-spec-list');
|
||||
} else {
|
||||
this.#setMenuModeTo('jasmine-failure-list');
|
||||
}
|
||||
}
|
||||
);
|
||||
this.#alerts.addBar(this.#tabBar.rootEl);
|
||||
|
||||
this.#progress = new ProgressView();
|
||||
this.#banner = new j$.private.Banner(
|
||||
this.#queryString.navigateWithNewParam.bind(this.#queryString),
|
||||
@@ -160,13 +180,11 @@ jasmineRequire.HtmlReporterV2 = function(j$) {
|
||||
results.appendChild(summary.rootEl);
|
||||
|
||||
if (this.#stateBuilder.anyNonTopSuiteFailures) {
|
||||
this.#alerts.addFailureToggle(
|
||||
() => this.#setMenuModeTo('jasmine-failure-list'),
|
||||
() => this.#setMenuModeTo('jasmine-spec-list')
|
||||
);
|
||||
|
||||
this.#setMenuModeTo('jasmine-failure-list');
|
||||
this.#failures.show();
|
||||
this.#tabBar.showTab(specListTabId);
|
||||
this.#tabBar.showTab(failuresTabId);
|
||||
this.#tabBar.selectTab(failuresTabId);
|
||||
} else {
|
||||
this.#tabBar.selectTab(specListTabId);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -205,7 +223,6 @@ jasmineRequire.HtmlReporterV2 = function(j$) {
|
||||
this.rootEl.value = this.rootEl.value + 1;
|
||||
|
||||
if (result.status === 'failed') {
|
||||
// TODO: also a non-color indicator
|
||||
this.rootEl.classList.add('failed');
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user