admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

When catching a global error in Node.js, print the type of error

Browse Source
This commit is contained in:
James Bunton
2018-12-06 22:00:34 +11:00
parent a621d05fa7
commit d803bd12a6
5 changed files with 39 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spec/core/GlobalErrorsSpec.js
View File

@@ -98,9 +98,11 @@ describe("GlobalErrors", function() {
errors.pushListener(handler);
var addedListener = fakeGlobal.process.on.calls.argsFor(0)[1];
addedListener(new Error('bar'));
const expectedError = new Error('bar');
addedListener(expectedError);
expect(handler).toHaveBeenCalledWith(new Error('bar'));
expect(handler).toHaveBeenCalledWith(expectedError);
expect(expectedError.jasmineMessage).toBe('Uncaught exception: Error: bar');
errors.uninstall();
@@ -127,10 +129,12 @@ describe("GlobalErrors", function() {
errors.pushListener(handler);
var addedListener = fakeGlobal.process.on.calls.argsFor(0)[1];
addedListener(new Error('bar'));
var addedListener = fakeGlobal.process.on.calls.argsFor(1)[1];
const expectedError = new Error('bar');
addedListener(expectedError);
expect(handler).toHaveBeenCalledWith(new Error('bar'));
expect(handler).toHaveBeenCalledWith(expectedError);
expect(expectedError.jasmineMessage).toBe('Unhandled promise rejection: Error: bar');
errors.uninstall();

4
spec/core/integration/EnvSpec.js
View File

@@ -1942,10 +1942,10 @@ describe("Env integration", function() {
reporter.jasmineDone.and.callFake(function() {
expect(reporter.suiteDone).toHaveFailedExpectationsForRunnable('async suite', [
/^(((Uncaught )?Error: suite( thrown)?)|(suite thrown))$/
/^(((Uncaught )?(exception: )?Error: suite( thrown)?)|(suite thrown))$/
]);
expect(reporter.specDone).toHaveFailedExpectationsForRunnable('suite async spec', [
/^(((Uncaught )?Error: spec( thrown)?)|(spec thrown))$/
/^(((Uncaught )?(exception: )?Error: spec( thrown)?)|(spec thrown))$/
]);
done();
});