admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add missing var in front of j$ to avoid polluting global namespace

Browse Source 
Users should only have 'jasmine' in global namespace, j$ should be
fully internal unless developing for jasmine

As brought up by Morten Maxild
This commit is contained in:
Sheel Choksi
2013-09-29 14:42:26 -07:00
parent 04e1d8420e
commit da33c7823e
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/jasmine-core/jasmine.js
View File

@@ -30,7 +30,7 @@ function getJasmineRequireObj() {
} }
getJasmineRequireObj().core = function(jRequire) { getJasmineRequireObj().core = function(jRequire) {
j$ = {}; var j$ = {};
jRequire.base(j$); jRequire.base(j$);
j$.util = jRequire.util(); j$.util = jRequire.util();

2
src/core/requireCore.js
View File

@@ -8,7 +8,7 @@ function getJasmineRequireObj() {
} }
getJasmineRequireObj().core = function(jRequire) { getJasmineRequireObj().core = function(jRequire) {
j$ = {}; var j$ = {};
jRequire.base(j$); jRequire.base(j$);
j$.util = jRequire.util(); j$.util = jRequire.util();