admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

IE 8 doesn't support defineProperty on non-DOM nodes, skip that kindof thing

Browse Source
This commit is contained in:
Gregg Van Hove
2015-10-26 17:41:30 -07:00
parent 77514bbb80
commit ea4c44904d
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
spec/core/SpyRegistrySpec.js
View File

@@ -38,6 +38,9 @@ describe("SpyRegistry", function() {
}); });
it("checks if it can be spied upon", function() { it("checks if it can be spied upon", function() {
// IE 8 doesn't support `definePropery` on non-DOM nodes
if (jasmine.getEnv().ieVersion < 9) { return; }
var scope = {}; var scope = {};
function myFunc() { function myFunc() {

8
src/core/SpyRegistry.js
View File

@@ -22,7 +22,13 @@ getJasmineRequireObj().SpyRegistry = function(j$) {
throw new Error(methodName + ' has already been spied upon'); throw new Error(methodName + ' has already been spied upon');
} }
var descriptor = Object.getOwnPropertyDescriptor(obj, methodName); var descriptor = undefined;
try {
descriptor = Object.getOwnPropertyDescriptor(obj, methodName);
} catch(e) {
// IE 8 doesn't support `definePropery` on non-DOM nodes
}
if (descriptor && !(descriptor.writable || descriptor.set)) { if (descriptor && !(descriptor.writable || descriptor.set)) {
throw new Error(methodName + ' is not declared writable or has no setter'); throw new Error(methodName + ' is not declared writable or has no setter');
} }