admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed "stop spec on expectation failure" checkbox in standalone

Browse Source 
Fixes [#178248968].
This commit is contained in:
Steve Gravrock
2021-06-01 08:47:55 -07:00
parent 5f4a1c4276
commit f2de1be96a
3 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/jasmine-core/jasmine-html.js
View File

@@ -565,7 +565,7 @@ jasmineRequire.HtmlReporter = function(j$) {
); );
throwCheckbox.checked = config.oneFailurePerSpec; throwCheckbox.checked = config.oneFailurePerSpec;
throwCheckbox.onclick = function() { throwCheckbox.onclick = function() {
navigateWithNewParam('throwFailures', !config.oneFailurePerSpec); navigateWithNewParam('oneFailurePerSpec', !config.oneFailurePerSpec);
}; };
var randomCheckbox = optionsMenuDom.querySelector( var randomCheckbox = optionsMenuDom.querySelector(

7
spec/html/HtmlReporterSpec.js
View File

@@ -802,7 +802,7 @@ describe('HtmlReporter', function() {
var throwingExpectationsUI = container.querySelector('.jasmine-throw'); var throwingExpectationsUI = container.querySelector('.jasmine-throw');
throwingExpectationsUI.click(); throwingExpectationsUI.click();
expect(navigateHandler).toHaveBeenCalledWith('throwFailures', true); expect(navigateHandler).toHaveBeenCalledWith('oneFailurePerSpec', true);
}); });
it('should navigate and change the setting to off', function() { it('should navigate and change the setting to off', function() {
@@ -831,7 +831,10 @@ describe('HtmlReporter', function() {
var throwingExpectationsUI = container.querySelector('.jasmine-throw'); var throwingExpectationsUI = container.querySelector('.jasmine-throw');
throwingExpectationsUI.click(); throwingExpectationsUI.click();
expect(navigateHandler).toHaveBeenCalledWith('throwFailures', false); expect(navigateHandler).toHaveBeenCalledWith(
'oneFailurePerSpec',
false
);
}); });
}); });
describe('UI for hiding disabled specs', function() { describe('UI for hiding disabled specs', function() {

2
src/html/HtmlReporter.js
View File

@@ -534,7 +534,7 @@ jasmineRequire.HtmlReporter = function(j$) {
); );
throwCheckbox.checked = config.oneFailurePerSpec; throwCheckbox.checked = config.oneFailurePerSpec;
throwCheckbox.onclick = function() { throwCheckbox.onclick = function() {
navigateWithNewParam('throwFailures', !config.oneFailurePerSpec); navigateWithNewParam('oneFailurePerSpec', !config.oneFailurePerSpec);
}; };
var randomCheckbox = optionsMenuDom.querySelector( var randomCheckbox = optionsMenuDom.querySelector(