From fbec066837fcc48113b231e27d73bd48b211bcd5 Mon Sep 17 00:00:00 2001 From: Steve Gravrock Date: Mon, 22 Sep 2025 21:53:27 -0700 Subject: [PATCH] rm unused deprecatingSpecProxy --- lib/jasmine-core/jasmine.js | 38 -------------------------------- src/core/deprecatingSpecProxy.js | 36 ------------------------------ src/core/requireCore.js | 1 - 3 files changed, 75 deletions(-) delete mode 100644 src/core/deprecatingSpecProxy.js diff --git a/lib/jasmine-core/jasmine.js b/lib/jasmine-core/jasmine.js index cc9769ce..e952ea2e 100644 --- a/lib/jasmine-core/jasmine.js +++ b/lib/jasmine-core/jasmine.js @@ -66,7 +66,6 @@ var getJasmineRequireObj = (function(jasmineGlobal) { j$.getClearStack = jRequire.clearStack(j$); j$.Clock = jRequire.Clock(); j$.DelayedFunctionScheduler = jRequire.DelayedFunctionScheduler(j$); - j$.deprecatingSpecProxy = jRequire.deprecatingSpecProxy(j$); j$.Deprecator = jRequire.Deprecator(j$); j$.Configuration = jRequire.Configuration(j$); j$.Env = jRequire.Env(j$); @@ -3735,43 +3734,6 @@ getJasmineRequireObj().DelayedFunctionScheduler = function(j$) { return DelayedFunctionScheduler; }; -// TODO: Remove this in the next major release. -getJasmineRequireObj().deprecatingSpecProxy = function(j$) { - const allowedMembers = ['id', 'description', 'getFullName', 'getPath']; - - function isMember(target, prop) { - return ( - Object.keys(target).indexOf(prop) !== -1 || - Object.keys(j$.Spec.prototype).indexOf(prop) !== -1 - ); - } - - function msg(member) { - const memberName = member.toString().replace(/^Symbol\((.+)\)$/, '$1'); - return ( - 'Access to private Spec members (in this case `' + - memberName + - '`) via spec filters is not supported and will break in ' + - 'a future release. See ' + - 'for correct usage.' - ); - } - - function deprecatingSpecProxy(spec, deprecated) { - return new Proxy(spec, { - get(target, prop, receiver) { - if (isMember(target, prop) && !allowedMembers.includes(prop)) { - deprecated(msg(prop)); - } - - return target[prop]; - } - }); - } - - return deprecatingSpecProxy; -}; - getJasmineRequireObj().Deprecator = function(j$) { function Deprecator(topSuite) { this.topSuite_ = topSuite; diff --git a/src/core/deprecatingSpecProxy.js b/src/core/deprecatingSpecProxy.js deleted file mode 100644 index eb1b583e..00000000 --- a/src/core/deprecatingSpecProxy.js +++ /dev/null @@ -1,36 +0,0 @@ -// TODO: Remove this in the next major release. -getJasmineRequireObj().deprecatingSpecProxy = function(j$) { - const allowedMembers = ['id', 'description', 'getFullName', 'getPath']; - - function isMember(target, prop) { - return ( - Object.keys(target).indexOf(prop) !== -1 || - Object.keys(j$.Spec.prototype).indexOf(prop) !== -1 - ); - } - - function msg(member) { - const memberName = member.toString().replace(/^Symbol\((.+)\)$/, '$1'); - return ( - 'Access to private Spec members (in this case `' + - memberName + - '`) via spec filters is not supported and will break in ' + - 'a future release. See ' + - 'for correct usage.' - ); - } - - function deprecatingSpecProxy(spec, deprecated) { - return new Proxy(spec, { - get(target, prop, receiver) { - if (isMember(target, prop) && !allowedMembers.includes(prop)) { - deprecated(msg(prop)); - } - - return target[prop]; - } - }); - } - - return deprecatingSpecProxy; -}; diff --git a/src/core/requireCore.js b/src/core/requireCore.js index 9ce8aed3..669bd244 100644 --- a/src/core/requireCore.js +++ b/src/core/requireCore.js @@ -42,7 +42,6 @@ var getJasmineRequireObj = (function(jasmineGlobal) { j$.getClearStack = jRequire.clearStack(j$); j$.Clock = jRequire.Clock(); j$.DelayedFunctionScheduler = jRequire.DelayedFunctionScheduler(j$); - j$.deprecatingSpecProxy = jRequire.deprecatingSpecProxy(j$); j$.Deprecator = jRequire.Deprecator(j$); j$.Configuration = jRequire.Configuration(j$); j$.Env = jRequire.Env(j$);