admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
3,042 Commits 1 Branch 0 Tags
434575f49d8fc71dcc81f259de82a806f464aa4e
Commit Graph

102 Commits

Author SHA1 Message Date
Steve Gravrock
434575f49d Use one declaration per statement 
The old style of merging all of a function's variable declarations into
a single statement made some sense back in the days of var, but there's
no reason to keep doing it now that we use const and let.
 2026-03-11 06:30:46 -07:00
Steve Gravrock
23894c1a0a Detect monkey patching and emit a deprecation warning. 
This isn't comprehensive but it should be broad enough to ensure that most
people who would be affected by blocking monkey patching see a warning.
Covers the jasmine namespace as well as classes that are monkey patched by
zone.js.

Replacing globals (describe/it/etc) doesn't trigger a warning because they
belong to the user and are expected to be replaced.
 2025-11-27 07:23:57 -08:00
Steve Gravrock
695a805844 Backfill missing HTML reporter tests 2025-10-15 19:32:47 -07:00
Steve Gravrock
9b3cc08818 Deprecate HtmlReporter and HtmlSpecFilter 2025-10-09 16:42:42 -07:00
Steve Gravrock
de44e909f2 Ignore HtmlReporter's createElement and createTextNode options 
Injected DOM wrappers were a nice idea in theory but everyone just passes
wrappers around document.createElement/document.createTextNode. That
includes HtmlReporter's unit tests and karma-jasmine-html-reporter, the
only known 5.x-compatible library that constructs an HtmlReporter.
 2025-10-09 16:42:42 -07:00
Steve Gravrock
cfd8f11b30 Merge branch '5.99' into 6.0 2025-10-05 10:08:40 -07:00
Steve Gravrock
dbc1f9244e Revert "Clicking a link in the HTML reporter does exact filtering" 
This change broke spec filtering in Karma by changing the format of the
`spec` query parameter. Although karma-jasmine-html-reporter uses
jasmine-core's HtmlSpecFilter, karm-jasmine provides its own spec filter
that interprets the query parameters itself.

This feature may be reintroduced in 6.0 as a breaking change.

This reverts commit 8309416cb2.
 2025-10-05 09:59:36 -07:00
Steve Gravrock
489b83c61b Revert "Move knowledge of query parameters out of boot1.js" 
This reverts commit 6715f24fd0.
 2025-10-05 09:54:25 -07:00
Steve Gravrock
168ff0a751 Move private APIs to private namespace 
Fixes #2078
 2025-09-27 13:21:09 -07:00
Steve Gravrock
6715f24fd0 Move knowledge of query parameters out of boot1.js 2025-09-17 18:23:45 -07:00
Steve Gravrock
8309416cb2 Clicking a link in the HTML reporter does exact filtering 
This feature requires an update to boot1.js, as shown in this commit.
Users with an older boot1.js will get the older inexact filtering.
 2025-09-17 07:30:20 -07:00
Kevin Bon
c6266b24b7 add test 2025-08-27 10:10:45 -04:00
Steve Gravrock
ff93277c0f Accessibility: Always provide a non-color indication that a spec is pending 2023-04-29 11:45:21 -07:00
Steve Gravrock
1166d10e43 Use const/let in specs, not var 2022-04-16 13:41:44 -07:00
Steve Gravrock
b8dabf96ff HTML: Include top suite failures in the reported failure count 2021-12-03 08:18:18 -08:00
Steve Gravrock
40fac8b6a2 Renamed the trace feature to debugLog[s] 
"trace" was ambiguous and could easily be understood to have something
to do with stack traces.
 2021-12-02 14:46:56 -08:00
Steve Gravrock
42e6c45efa Allow use without creating globals 
* Fixes #1235
 2021-11-29 20:37:07 -08:00
Steve Gravrock
47081258cd Revert "Revert "Added the ability to associate trace information with failing specs"" 
This reverts commit fdad8849df.
 2021-10-02 09:56:25 -07:00
Steve Gravrock
6e10f22403 Don't display late errors as AfterAll errors in the HTML reporter 2021-09-11 08:57:50 -07:00
Steve Gravrock
d8862aa583 Removed the failFast and oneFailurePerSpec config properties 2021-07-31 09:28:14 -07:00
Steve Gravrock
058e77b824 Merge branch 'main' into 3.99 2021-07-31 08:15:29 -07:00
Steve Gravrock
b696bec9e3 Renamed failFast and oneFailurePerSpec config props to stopOnSpecFailure and stopSpecOnExpectationFailure 
The new names are more self-explanatory and consistent with jasmine-npm. The
old names are deprecated but still work.

[#178682783]
 2021-07-31 07:51:50 -07:00
Steve Gravrock
6cb9507f62 Merge branch 'main' into 3.99 2021-07-10 08:58:14 -07:00
Joris Stolwijk
e4c7d8af45 new attempt for fixing #1906: add window.location.pathname to hrefs + comments + fixed tests 2021-06-29 14:03:25 +02:00
Steve Gravrock
f2de1be96a Fixed "stop spec on expectation failure" checkbox in standalone 
Fixes [#178248968].
 2021-06-01 08:49:34 -07:00
Steve Gravrock
6a2a30d540 Improved & unified deprecation handling 
* De-duplication now happens in core, not in reporters. This ensures that
  the console doesn't get flooded.
* Stack traces are opt-out, not opt-in.
* The current runnable is not reported or logged for certain deprecations
  where it's irrelevant.
* HtmlReporter shows stack traces in expandable widgets.
* Env#deprecated and Env#deprecatedOnceWithStack are merged.
 2021-05-29 15:39:28 -07:00
Steve Gravrock
7d5ca27b9d Check for forgotten console and debugger statements 2020-09-17 13:33:25 -07:00
Steve Gravrock
e7daa429a1 Show the name of the spec/suite that caused a deprecation 2020-09-13 12:59:25 -07:00
Steve Gravrock
7f392d188e Don't leak global error handlers between Jasmine's own tests 2020-01-20 10:18:29 -08:00
Dmitriy T
7263a38c3f Adds new configuration option to failSpecWithNoExpectations that will report specs without expectations as failures if enabled 2019-09-05 09:47:38 -07:00
Gregg Van Hove
3e888105f0 Calculate total suite run time inside the env and report in jasmineDone 2019-06-14 14:59:33 -07:00
Gregg Van Hove
984018bfdf Make no expectations in HTML Reporter message a warning 
- Fixes #1704
 2019-06-12 13:31:25 -07:00
Gregg Van Hove
b4cbe9850f add prettier and eslint 2019-05-21 18:23:48 -07:00
Gregg Van Hove
92d0882a32 Introduce a configuration object to Env deprecating old single use functions 
[finishes #159158038]
 2018-09-25 17:08:41 -07:00
SamFare
92d33c79c7 Implemented hiding of disabled specs 2018-05-22 13:30:33 +01:00
sylhare
7fb53dcdfa Fixing missing semi-colons 2018-02-21 09:01:24 -05:00
Gregg Van Hove
764d58a7f5 Merge branch 'master' into 3.0-features 
- cleaning up 2.99 deprecations
 2018-02-06 09:31:51 -08:00
Gregg Van Hove
24bf3489dc Display deprecation warnings in HTML reporter 
- Also no longer check for stack since IE doesn't do that

[#154746527]
 2018-02-05 12:11:36 -08:00
Gregg Van Hove
0eca06a33b Now pass a navigation helper to HtmlReporter instead of click handlers 2018-01-30 14:30:28 -08:00
Gregg Van Hove
e15f273f06 Replace old "catch exceptions" logic with proper fail fast with error reporting 
- Option is called stopOnSpecFailure

[#85966014]
- See #414
- See jasmine/jasmine-npm#16
 2018-01-30 11:36:56 -08:00
Gregg Van Hove
341c6df6ea Fix HTML reporter display for excluded specs 2018-01-29 10:00:15 -08:00
Elenore Bastian
07996b567f Suite level errors are reported in failures list 
[#150118881]

Signed-off-by: Gregg Van Hove <gvanhove@pivotal.io>
 2018-01-23 15:39:11 -08:00
Steve Gravrock
cf2f922e30 Merge branch 'master' into 3.0-features 2018-01-10 15:28:55 -08:00
Steve Gravrock
b943f6b736 Fixed SPEC HAS NO EXPECTATIONS warning in HTML reporter 
[Finishes #153891435]
 2017-12-23 11:14:37 -08:00
Steve Gravrock
f38527ff15 Removed IE 8 compatibility cruft from HtmlReporterSpec 2017-12-19 11:29:21 -08:00
Steve Gravrock
d742ada71d Added links to re-run the suites containing a failing spec 
[Finishes #25508053]
 2017-12-19 11:29:18 -08:00
Steve Gravrock
2d33765cbf Dogfood the toHaveClass matcher 
[#153567695]
 2017-12-11 16:00:29 -08:00
Steve Gravrock
db615e4186 Determine overall status in core, not reporters 
[#92261606]
[#78679648]
 2017-11-17 14:24:12 -08:00
Steve Gravrock
1526d5e2a8 Treat afterAll errors at any level as failures 
[Finishes #152492514]
 2017-11-07 20:48:23 -08:00
Steve Gravrock
82eeed3c85 Improved reporting of load errors and afterAll errors 
- Pass file and line number to reporters when present
- Show file and line number in the HTML reporter when present
- Visually separate adjacent errors in the HTML reporter

[#24901981]
 2017-11-04 10:28:42 -07:00