6a2a30d540
* De-duplication now happens in core, not in reporters. This ensures that the console doesn't get flooded. * Stack traces are opt-out, not opt-in. * The current runnable is not reported or logged for certain deprecations where it's irrelevant. * HtmlReporter shows stack traces in expandable widgets. * Env#deprecated and Env#deprecatedOnceWithStack are merged.
323 lines
9.2 KiB
JavaScript
323 lines
9.2 KiB
JavaScript
/* eslint no-console: 0 */
|
|
describe('Deprecation (integration)', function() {
|
|
var env;
|
|
|
|
beforeEach(function() {
|
|
env = new jasmineUnderTest.Env();
|
|
});
|
|
|
|
afterEach(function() {
|
|
env.cleanup_();
|
|
});
|
|
|
|
it('reports a deprecation on the top suite', function(done) {
|
|
var reporter = jasmine.createSpyObj('reporter', ['jasmineDone']);
|
|
env.addReporter(reporter);
|
|
spyOn(console, 'error');
|
|
|
|
env.beforeAll(function() {
|
|
env.deprecated('the message');
|
|
});
|
|
env.it('a spec', function() {});
|
|
|
|
env.execute(null, function() {
|
|
expect(reporter.jasmineDone).toHaveBeenCalledWith(
|
|
jasmine.objectContaining({
|
|
deprecationWarnings: [
|
|
jasmine.objectContaining({
|
|
message: jasmine.stringMatching(/^the message/)
|
|
})
|
|
]
|
|
})
|
|
);
|
|
expect(console.error).toHaveBeenCalledWith(
|
|
jasmine.stringMatching(/^DEPRECATION: the message/)
|
|
);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('reports a deprecation on a descendent suite', function(done) {
|
|
var reporter = jasmine.createSpyObj('reporter', ['suiteDone']);
|
|
env.addReporter(reporter);
|
|
spyOn(console, 'error');
|
|
|
|
env.describe('a suite', function() {
|
|
env.beforeAll(function() {
|
|
env.deprecated('the message');
|
|
});
|
|
env.it('a spec', function() {});
|
|
});
|
|
|
|
env.execute(null, function() {
|
|
expect(reporter.suiteDone).toHaveBeenCalledWith(
|
|
jasmine.objectContaining({
|
|
deprecationWarnings: [
|
|
jasmine.objectContaining({
|
|
message: jasmine.stringMatching(/^the message/)
|
|
})
|
|
]
|
|
})
|
|
);
|
|
expect(console.error).toHaveBeenCalledWith(
|
|
jasmine.stringMatching(
|
|
/^DEPRECATION: the message \(in suite: a suite\)/
|
|
)
|
|
);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('reports a deprecation on a spec', function(done) {
|
|
var reporter = jasmine.createSpyObj('reporter', ['specDone']);
|
|
env.addReporter(reporter);
|
|
spyOn(console, 'error');
|
|
|
|
env.describe('a suite', function() {
|
|
env.it('a spec', function() {
|
|
env.deprecated('the message');
|
|
});
|
|
});
|
|
|
|
env.execute(null, function() {
|
|
expect(reporter.specDone).toHaveBeenCalledWith(
|
|
jasmine.objectContaining({
|
|
deprecationWarnings: [
|
|
jasmine.objectContaining({
|
|
message: jasmine.stringMatching(/^the message/)
|
|
})
|
|
]
|
|
})
|
|
);
|
|
expect(console.error).toHaveBeenCalledWith(
|
|
jasmine.stringMatching(
|
|
/^DEPRECATION: the message \(in spec: a suite a spec\)/
|
|
)
|
|
);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('omits the suite or spec context when ignoreRunnable is true', function(done) {
|
|
var reporter = jasmine.createSpyObj('reporter', ['jasmineDone']);
|
|
env.addReporter(reporter);
|
|
spyOn(console, 'error');
|
|
|
|
env.it('a spec', function() {
|
|
env.deprecated('the message', { ignoreRunnable: true });
|
|
});
|
|
|
|
env.execute(null, function() {
|
|
expect(reporter.jasmineDone).toHaveBeenCalledWith(
|
|
jasmine.objectContaining({
|
|
deprecationWarnings: [
|
|
jasmine.objectContaining({
|
|
message: jasmine.stringMatching(/^the message/)
|
|
})
|
|
]
|
|
})
|
|
);
|
|
expect(console.error).toHaveBeenCalledWith(
|
|
jasmine.stringMatching(/the message/)
|
|
);
|
|
expect(console.error).not.toHaveBeenCalledWith(
|
|
jasmine.stringMatching(/a spec/)
|
|
);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('includes the stack trace', function(done) {
|
|
var reporter = jasmine.createSpyObj('reporter', ['specDone']);
|
|
env.addReporter(reporter);
|
|
spyOn(console, 'error');
|
|
|
|
env.describe('a suite', function() {
|
|
env.it('a spec', function() {
|
|
env.deprecated('the message');
|
|
});
|
|
});
|
|
|
|
env.execute(null, function() {
|
|
expect(reporter.specDone).toHaveBeenCalledWith(
|
|
jasmine.objectContaining({
|
|
deprecationWarnings: [
|
|
jasmine.objectContaining({
|
|
stack: jasmine.stringMatching(/DeprecationSpec.js/)
|
|
})
|
|
]
|
|
})
|
|
);
|
|
expect(console.error).toHaveBeenCalled();
|
|
expect(console.error.calls.argsFor(0)[0].replace(/\n/g, 'NL')).toMatch(
|
|
/^DEPRECATION: the message \(in spec: a suite a spec\)NL.*DeprecationSpec.js/
|
|
);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('excludes the stack trace when omitStackTrace is true', function(done) {
|
|
var reporter = jasmine.createSpyObj('reporter', ['specDone']);
|
|
env.addReporter(reporter);
|
|
spyOn(console, 'error');
|
|
|
|
env.describe('a suite', function() {
|
|
env.it('a spec', function() {
|
|
env.deprecated('the message', { omitStackTrace: true });
|
|
});
|
|
});
|
|
|
|
env.execute(null, function() {
|
|
expect(reporter.specDone).toHaveBeenCalledWith(
|
|
jasmine.objectContaining({
|
|
deprecationWarnings: [
|
|
jasmine.objectContaining({
|
|
stack: jasmine.falsy()
|
|
})
|
|
]
|
|
})
|
|
);
|
|
expect(console.error).toHaveBeenCalled();
|
|
expect(console.error).not.toHaveBeenCalledWith(
|
|
jasmine.stringMatching(/DeprecationSpec.js/)
|
|
);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('emits a given deprecation only once', function(done) {
|
|
var reporter = jasmine.createSpyObj('reporter', ['specDone', 'suiteDone']);
|
|
env.addReporter(reporter);
|
|
spyOn(console, 'error');
|
|
|
|
env.describe('a suite', function() {
|
|
env.beforeAll(function() {
|
|
env.deprecated('the message');
|
|
env.deprecated('the message');
|
|
});
|
|
|
|
env.it('a spec', function() {
|
|
env.deprecated('the message');
|
|
env.deprecated('a different message');
|
|
});
|
|
});
|
|
|
|
env.execute(null, function() {
|
|
expect(reporter.suiteDone).toHaveBeenCalledWith(
|
|
jasmine.objectContaining({
|
|
deprecationWarnings: [
|
|
// only one
|
|
jasmine.objectContaining({
|
|
message: jasmine.stringMatching(/^the message/)
|
|
})
|
|
]
|
|
})
|
|
);
|
|
expect(reporter.specDone).toHaveBeenCalledWith(
|
|
jasmine.objectContaining({
|
|
deprecationWarnings: [
|
|
// only the other one
|
|
jasmine.objectContaining({
|
|
message: jasmine.stringMatching(/^a different message/)
|
|
})
|
|
]
|
|
})
|
|
);
|
|
expect(console.error).toHaveBeenCalledTimes(2);
|
|
expect(console.error).toHaveBeenCalledWith(
|
|
jasmine.stringMatching(
|
|
/^DEPRECATION: the message \(in suite: a suite\)/
|
|
)
|
|
);
|
|
expect(console.error).toHaveBeenCalledWith(
|
|
jasmine.stringMatching(
|
|
/^DEPRECATION: a different message \(in spec: a suite a spec\)/
|
|
)
|
|
);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('emits a given deprecation each time when config.verboseDeprecations is true', function(done) {
|
|
var reporter = jasmine.createSpyObj('reporter', ['specDone', 'suiteDone']);
|
|
env.addReporter(reporter);
|
|
spyOn(console, 'error');
|
|
|
|
env.configure({ verboseDeprecations: true });
|
|
|
|
env.describe('a suite', function() {
|
|
env.beforeAll(function() {
|
|
env.deprecated('the message');
|
|
env.deprecated('the message');
|
|
});
|
|
|
|
env.it('a spec', function() {
|
|
env.deprecated('the message');
|
|
});
|
|
});
|
|
|
|
env.execute(null, function() {
|
|
expect(reporter.suiteDone).toHaveBeenCalledWith(
|
|
jasmine.objectContaining({
|
|
deprecationWarnings: [
|
|
jasmine.objectContaining({
|
|
message: jasmine.stringMatching(/^the message/)
|
|
}),
|
|
jasmine.objectContaining({
|
|
message: jasmine.stringMatching(/^the message/)
|
|
})
|
|
]
|
|
})
|
|
);
|
|
expect(reporter.specDone).toHaveBeenCalledWith(
|
|
jasmine.objectContaining({
|
|
deprecationWarnings: [
|
|
jasmine.objectContaining({
|
|
message: jasmine.stringMatching(/^the message/)
|
|
})
|
|
]
|
|
})
|
|
);
|
|
expect(console.error).toHaveBeenCalledTimes(3);
|
|
expect(console.error.calls.argsFor(0)[0]).toMatch(
|
|
/^DEPRECATION: the message \(in suite: a suite\)/
|
|
);
|
|
expect(console.error.calls.argsFor(1)[0]).toMatch(
|
|
/^DEPRECATION: the message \(in suite: a suite\)/
|
|
);
|
|
expect(console.error.calls.argsFor(2)[0]).toMatch(
|
|
/^DEPRECATION: the message \(in spec: a suite a spec\)/
|
|
);
|
|
expect(console.error.calls.argsFor(2)[0]).toMatch(
|
|
/^DEPRECATION: the message \(in spec: a suite a spec\)/
|
|
);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('handles deprecations that occur before execute() is called', function(done) {
|
|
var reporter = jasmine.createSpyObj('reporter', ['jasmineDone']);
|
|
env.addReporter(reporter);
|
|
spyOn(console, 'error');
|
|
|
|
env.deprecated('the message');
|
|
env.it('a spec', function() {});
|
|
|
|
env.execute(null, function() {
|
|
expect(reporter.jasmineDone).toHaveBeenCalledWith(
|
|
jasmine.objectContaining({
|
|
deprecationWarnings: [
|
|
jasmine.objectContaining({
|
|
message: jasmine.stringMatching(/^the message/)
|
|
})
|
|
]
|
|
})
|
|
);
|
|
expect(console.error).toHaveBeenCalledWith(
|
|
jasmine.stringMatching(/^DEPRECATION: the message/)
|
|
);
|
|
done();
|
|
});
|
|
});
|
|
});
|