From 03fe4d73f7b13fb890225020d0171c4b99ec9026 Mon Sep 17 00:00:00 2001 From: Peter Lieven Date: Mon, 2 May 2016 10:08:01 +0200 Subject: [PATCH] iscsi-command: DATA OUT PDUs must have no callback otherwise we might invoke a cmd_pdu callback multiple times on timeout or reconnect. Signed-off-by: Peter Lieven --- lib/iscsi-command.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/iscsi-command.c b/lib/iscsi-command.c index 063f633..838890f 100644 --- a/lib/iscsi-command.c +++ b/lib/iscsi-command.c @@ -131,9 +131,6 @@ iscsi_send_data_out(struct iscsi_context *iscsi, struct iscsi_pdu *cmd_pdu, /* update data segment length */ scsi_set_uint32(&pdu->outdata.data[4], pdu->payload_len); - pdu->callback = cmd_pdu->callback; - pdu->private_data = cmd_pdu->private_data; - if (iscsi_queue_pdu(iscsi, pdu) != 0) { iscsi_set_error(iscsi, "Out-of-memory: failed to queue iscsi " "scsi pdu.");