From 0c124ce3ccf608f4fb3c4ea5831b9bac51e09c8f Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Mon, 21 Jan 2013 08:36:23 -0800 Subject: [PATCH] TESTS Add READ16 tests to the new framework --- Makefile.am | 5 ++ test-tool/iscsi-support.c | 129 +++++++++++++++++++++++++++++ test-tool/iscsi-support.h | 3 + test-tool/iscsi-test-cu.c | 11 +++ test-tool/iscsi-test-cu.h | 6 ++ test-tool/test_read12_0blocks.c | 2 +- test-tool/test_read16_0blocks.c | 58 +++++++++++++ test-tool/test_read16_beyond_eol.c | 66 +++++++++++++++ test-tool/test_read16_flags.c | 76 +++++++++++++++++ test-tool/test_read16_rdprotect.c | 51 ++++++++++++ test-tool/test_read16_simple.c | 50 +++++++++++ 11 files changed, 456 insertions(+), 1 deletion(-) create mode 100644 test-tool/test_read16_0blocks.c create mode 100644 test-tool/test_read16_beyond_eol.c create mode 100644 test-tool/test_read16_flags.c create mode 100644 test-tool/test_read16_rdprotect.c create mode 100644 test-tool/test_read16_simple.c diff --git a/Makefile.am b/Makefile.am index 60fe904..e72062a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -191,6 +191,11 @@ bin_iscsi_test_cu_SOURCES = test-tool/iscsi-test-cu.c \ test-tool/test_read12_0blocks.c \ test-tool/test_read12_rdprotect.c \ test-tool/test_read12_flags.c \ + test-tool/test_read16_simple.c \ + test-tool/test_read16_beyond_eol.c \ + test-tool/test_read16_0blocks.c \ + test-tool/test_read16_rdprotect.c \ + test-tool/test_read16_flags.c \ test-tool/test_readcapacity10_simple.c endif diff --git a/test-tool/iscsi-support.c b/test-tool/iscsi-support.c index b62c3b0..7b80d97 100644 --- a/test-tool/iscsi-support.c +++ b/test-tool/iscsi-support.c @@ -1272,6 +1272,135 @@ read12_lbaoutofrange(struct iscsi_context *iscsi, int lun, uint32_t lba, return 0; } +int +read16(struct iscsi_context *iscsi, int lun, uint64_t lba, + uint32_t datalen, int blocksize, int rdprotect, + int dpo, int fua, int fua_nv, int group, + unsigned char *data) +{ + struct scsi_task *task; + + logging(LOG_VERBOSE, "Send READ16 LBA:%" PRId64 " blocks:%d " + "rdprotect:%d dpo:%d fua:%d fua_nv:%d group:%d", + lba, datalen / blocksize, rdprotect, + dpo, fua, fua_nv, group); + + task = iscsi_read16_sync(iscsi, lun, lba, datalen, blocksize, + rdprotect, dpo, fua, fua_nv, group); + if (task == NULL) { + logging(LOG_NORMAL, "[FAILED] Failed to send READ16 command: %s", + iscsi_get_error(iscsi)); + return -1; + } + if (task->status != SCSI_STATUS_GOOD) { + logging(LOG_NORMAL, "[FAILED] READ16 command: " + "failed with sense. %s", iscsi_get_error(iscsi)); + scsi_free_scsi_task(task); + return -1; + } + + if (data != NULL) { + memcpy(data, task->datain.data, task->datain.size); + } + + scsi_free_scsi_task(task); + logging(LOG_VERBOSE, "[OK] READ16 returned SUCCESS."); + return 0; +} + +int +read16_invalidfieldincdb(struct iscsi_context *iscsi, int lun, uint64_t lba, + uint32_t datalen, int blocksize, int rdprotect, + int dpo, int fua, int fua_nv, int group, + unsigned char *data) +{ + struct scsi_task *task; + + logging(LOG_VERBOSE, "Send READ16 (Expecting INVALID_FIELD_IN_CDB) " + "LBA:%" PRId64 " blocks:%d rdprotect:%d " + "dpo:%d fua:%d fua_nv:%d group:%d", + lba, datalen / blocksize, rdprotect, + dpo, fua, fua_nv, group); + + task = iscsi_read16_sync(iscsi, lun, lba, datalen, blocksize, + rdprotect, dpo, fua, fua_nv, group); + if (task == NULL) { + logging(LOG_NORMAL, "[FAILED] Failed to send READ16 command: %s", + iscsi_get_error(iscsi)); + return -1; + } + if (task->status == SCSI_STATUS_GOOD) { + logging(LOG_NORMAL, "[FAILED] READ16 successful but should " + "have failed with ILLEGAL_REQUEST/INVALID_FIELD_IN_CDB"); + scsi_free_scsi_task(task); + return -1; + } + if (task->status != SCSI_STATUS_CHECK_CONDITION + || task->sense.key != SCSI_SENSE_ILLEGAL_REQUEST + || task->sense.ascq != SCSI_SENSE_ASCQ_INVALID_FIELD_IN_CDB) { + logging(LOG_NORMAL, "[FAILED] READ16 failed with wrong sense. " + "Should have failed with ILLEGAL_REQUEST/" + "INVALID_FIELD_IN_CDB. Sense:%s\n", + iscsi_get_error(iscsi)); + scsi_free_scsi_task(task); + return -1; + } + + if (data != NULL) { + memcpy(data, task->datain.data, task->datain.size); + } + + scsi_free_scsi_task(task); + logging(LOG_VERBOSE, "[OK] READ16 returned ILLEGAL_REQUEST/INVALID_FIELD_IB_CDB."); + return 0; +} + +int +read16_lbaoutofrange(struct iscsi_context *iscsi, int lun, uint64_t lba, + uint32_t datalen, int blocksize, int rdprotect, + int dpo, int fua, int fua_nv, int group, + unsigned char *data) +{ + struct scsi_task *task; + + logging(LOG_VERBOSE, "Send READ16 (Expecting LBA_OUT_OF_RANGE) " + "LBA:%" PRId64 " blocks:%d rdprotect:%d " + "dpo:%d fua:%d fua_nv:%d group:%d", + lba, datalen / blocksize, rdprotect, + dpo, fua, fua_nv, group); + + task = iscsi_read16_sync(iscsi, lun, lba, datalen, blocksize, + rdprotect, dpo, fua, fua_nv, group); + if (task == NULL) { + logging(LOG_NORMAL, "[FAILED] Failed to send READ16 command: %s", + iscsi_get_error(iscsi)); + return -1; + } + if (task->status == SCSI_STATUS_GOOD) { + logging(LOG_NORMAL, "[FAILED] READ16 successful but should " + "have failed with ILLEGAL_REQUEST/LBA_OUT_OF_RANGE"); + scsi_free_scsi_task(task); + return -1; + } + if (task->status != SCSI_STATUS_CHECK_CONDITION + || task->sense.key != SCSI_SENSE_ILLEGAL_REQUEST + || task->sense.ascq != SCSI_SENSE_ASCQ_LBA_OUT_OF_RANGE) { + logging(LOG_NORMAL, "[FAILED] READ16 failed with wrong sense. " + "Should have failed with ILLEGAL_REQUEST/" + "LBA_OUT_OF_RANGE. Sense:%s\n", iscsi_get_error(iscsi)); + scsi_free_scsi_task(task); + return -1; + } + + if (data != NULL) { + memcpy(data, task->datain.data, task->datain.size); + } + + scsi_free_scsi_task(task); + logging(LOG_VERBOSE, "[OK] READ16 returned ILLEGAL_REQUEST/LBA_OUT_OF_RANGE."); + return 0; +} + int readcapacity10(struct iscsi_context *iscsi, int lun, uint32_t lba, int pmi) { diff --git a/test-tool/iscsi-support.h b/test-tool/iscsi-support.h index fb9404d..b8aedcd 100644 --- a/test-tool/iscsi-support.h +++ b/test-tool/iscsi-support.h @@ -127,6 +127,9 @@ int read10_lbaoutofrange(struct iscsi_context *iscsi, int lun, uint32_t lba, uin int read12(struct iscsi_context *iscsi, int lun, uint32_t lba, uint32_t datalen, int blocksize, int rdprotect, int dpo, int fua, int fua_nv, int group, unsigned char *data); int read12_invalidfieldincdb(struct iscsi_context *iscsi, int lun, uint32_t lba, uint32_t datalen, int blocksize, int rdprotect, int dpo, int fua, int fua_nv, int group, unsigned char *data); int read12_lbaoutofrange(struct iscsi_context *iscsi, int lun, uint32_t lba, uint32_t datalen, int blocksize, int rdprotect, int dpo, int fua, int fua_nv, int group, unsigned char *data); +int read16(struct iscsi_context *iscsi, int lun, uint64_t lba, uint32_t datalen, int blocksize, int rdprotect, int dpo, int fua, int fua_nv, int group, unsigned char *data); +int read16_invalidfieldincdb(struct iscsi_context *iscsi, int lun, uint64_t lba, uint32_t datalen, int blocksize, int rdprotect, int dpo, int fua, int fua_nv, int group, unsigned char *data); +int read16_lbaoutofrange(struct iscsi_context *iscsi, int lun, uint64_t lba, uint32_t datalen, int blocksize, int rdprotect, int dpo, int fua, int fua_nv, int group, unsigned char *data); int readcapacity10(struct iscsi_context *iscsi, int lun, uint32_t lba, int pmi); int verify10(struct iscsi_context *iscsi, int lun, unsigned char *data, uint32_t datalen, uint32_t lba, int vprotect, int dpo, int bytchk, int blocksize); int verify10_nomedium(struct iscsi_context *iscsi, int lun, unsigned char *data, uint32_t datalen, uint32_t lba, int vprotect, int dpo, int bytchk, int blocksize); diff --git a/test-tool/iscsi-test-cu.c b/test-tool/iscsi-test-cu.c index 14b1079..10c1536 100644 --- a/test-tool/iscsi-test-cu.c +++ b/test-tool/iscsi-test-cu.c @@ -88,6 +88,15 @@ static CU_TestInfo tests_read12[] = { CU_TEST_INFO_NULL }; +static CU_TestInfo tests_read16[] = { + { (char *)"testRead16Simple", test_read16_simple }, + { (char *)"testRead16BeyondEol", test_read16_beyond_eol }, + { (char *)"testRead16ZeroBlocks", test_read16_0blocks }, + { (char *)"testRead16ReadProtect", test_read16_rdprotect }, + { (char *)"testRead16Flags", test_read16_flags }, + CU_TEST_INFO_NULL +}; + static CU_TestInfo tests_readcapacity10[] = { { (char *)"testReadCapacity10Simple", test_readcapacity10_simple }, CU_TEST_INFO_NULL @@ -102,6 +111,8 @@ static CU_SuiteInfo suites[] = { tests_read10 }, { (char *)"TestRead12", test_setup, test_teardown, tests_read12 }, + { (char *)"TestRead16", test_setup, test_teardown, + tests_read16 }, { (char *)"TestReadCapacity10", test_setup, test_teardown, tests_readcapacity10 }, CU_SUITE_INFO_NULL diff --git a/test-tool/iscsi-test-cu.h b/test-tool/iscsi-test-cu.h index 68394cb..1811d05 100644 --- a/test-tool/iscsi-test-cu.h +++ b/test-tool/iscsi-test-cu.h @@ -56,6 +56,12 @@ void test_read12_0blocks(void); void test_read12_rdprotect(void); void test_read12_flags(void); +void test_read16_simple(void); +void test_read16_beyond_eol(void); +void test_read16_0blocks(void); +void test_read16_rdprotect(void); +void test_read16_flags(void); + void test_readcapacity10_simple(void); #endif /* _ISCSI_TEST_CU_H_ */ diff --git a/test-tool/test_read12_0blocks.c b/test-tool/test_read12_0blocks.c index 05a894f..33f9a09 100644 --- a/test-tool/test_read12_0blocks.c +++ b/test-tool/test_read12_0blocks.c @@ -52,7 +52,7 @@ test_read12_0blocks(void) logging(LOG_VERBOSE, "Test READ12 0-blocks at LBA==-1"); - ret = read10_lbaoutofrange(iscsic, tgt_lun, -1, 0, block_size, + ret = read12_lbaoutofrange(iscsic, tgt_lun, -1, 0, block_size, 0, 0, 0, 0, 0, NULL); CU_ASSERT_EQUAL(ret, 0); } diff --git a/test-tool/test_read16_0blocks.c b/test-tool/test_read16_0blocks.c new file mode 100644 index 0000000..8e7739f --- /dev/null +++ b/test-tool/test_read16_0blocks.c @@ -0,0 +1,58 @@ +/* + Copyright (C) 2013 Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include + +#include + +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-test-cu.h" + +void +test_read16_0blocks(void) +{ + int ret; + + logging(LOG_VERBOSE, ""); + logging(LOG_VERBOSE, "Test READ16 0-blocks at LBA==0"); + ret = read16(iscsic, tgt_lun, 0, 0, block_size, + 0, 0, 0, 0, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + + if (num_blocks > 0x80000000) { + CU_PASS("[SKIPPED] LUN is too big"); + return; + } + + logging(LOG_VERBOSE, "Test READ16 0-blocks one block past end-of-LUN"); + ret = read16_lbaoutofrange(iscsic, tgt_lun, num_blocks + 1, 0, + block_size, 0, 0, 0, 0, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + + + logging(LOG_VERBOSE, "Test READ16 0-blocks at LBA==2^63"); + ret = read16_lbaoutofrange(iscsic, tgt_lun, 0x8000000000000000, 0, + block_size, 0, 0, 0, 0, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + + + logging(LOG_VERBOSE, "Test READ16 0-blocks at LBA==-1"); + ret = read16_lbaoutofrange(iscsic, tgt_lun, -1, 0, block_size, + 0, 0, 0, 0, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); +} diff --git a/test-tool/test_read16_beyond_eol.c b/test-tool/test_read16_beyond_eol.c new file mode 100644 index 0000000..67d262d --- /dev/null +++ b/test-tool/test_read16_beyond_eol.c @@ -0,0 +1,66 @@ +/* + Copyright (C) 2013 Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include + +#include + +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-test-cu.h" + + +void +test_read16_beyond_eol(void) +{ + int i, ret; + + logging(LOG_VERBOSE, ""); + logging(LOG_VERBOSE, "Test READ16 1-256 blocks one block beyond the end"); + for (i = 1; i <= 256; i++) { + ret = read16_lbaoutofrange(iscsic, tgt_lun, num_blocks + 2 - i, + i * block_size, block_size, + 0, 0, 0, 0, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + } + + + logging(LOG_VERBOSE, "Test READ16 1-256 blocks at LBA==2^63"); + for (i = 1; i <= 256; i++) { + ret = read16_lbaoutofrange(iscsic, tgt_lun, 0x8000000000000000, + i * block_size, block_size, + 0, 0, 0, 0, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + } + + + logging(LOG_VERBOSE, "Test READ16 1-256 blocks at LBA==-1"); + for (i = 1; i <= 256; i++) { + ret = read16_lbaoutofrange(iscsic, tgt_lun, -1, i * block_size, + block_size, 0, 0, 0, 0, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + } + + + logging(LOG_VERBOSE, "Test READ16 2-256 blocks all but one block beyond the end"); + for (i = 2; i <= 256; i++) { + ret = read16_lbaoutofrange(iscsic, tgt_lun, num_blocks, + i * block_size, block_size, + 0, 0, 0, 0, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + } +} diff --git a/test-tool/test_read16_flags.c b/test-tool/test_read16_flags.c new file mode 100644 index 0000000..1ca971c --- /dev/null +++ b/test-tool/test_read16_flags.c @@ -0,0 +1,76 @@ +/* + Copyright (C) 2013 Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include +#include +#include + +#include + +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-test-cu.h" + +void +test_read16_flags(void) +{ + int ret; + + logging(LOG_VERBOSE, ""); + logging(LOG_VERBOSE, "Test READ16 flags"); + + /* This test is only valid for SBC devices */ + if (device_type != SCSI_INQUIRY_PERIPHERAL_DEVICE_TYPE_DIRECT_ACCESS) { + CU_PASS("[SKIPPED] LUN is not SBC device. Skipping test"); + return; + } + + + logging(LOG_VERBOSE, "Test READ16 with DPO==1"); + ret = read16(iscsic, tgt_lun, 0, + block_size, block_size, + 0, 1, 0, 0, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + + + logging(LOG_VERBOSE, "Test READ16 with FUA==1 FUA_NV==0"); + ret = read16(iscsic, tgt_lun, 0, + block_size, block_size, + 0, 0, 1, 0, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + + + logging(LOG_VERBOSE, "Test READ16 with FUA==1 FUA_NV==1"); + ret = read16(iscsic, tgt_lun, 0, + block_size, block_size, + 0, 0, 1, 1, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + + + logging(LOG_VERBOSE, "Test READ16 with FUA==0 FUA_NV==1"); + ret = read16(iscsic, tgt_lun, 0, + block_size, block_size, + 0, 0, 0, 1, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + + + logging(LOG_VERBOSE, "Test READ16 with DPO==1 FUA==1 FUA_NV==1"); + ret = read12(iscsic, tgt_lun, 0, + block_size, block_size, + 0, 1, 1, 1, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); +} diff --git a/test-tool/test_read16_rdprotect.c b/test-tool/test_read16_rdprotect.c new file mode 100644 index 0000000..d1861fb --- /dev/null +++ b/test-tool/test_read16_rdprotect.c @@ -0,0 +1,51 @@ +/* + Copyright (C) 2013 Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include +#include +#include + +#include + +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-test-cu.h" + +void +test_read16_rdprotect(void) +{ + int i, ret; + + + if (device_type != SCSI_INQUIRY_PERIPHERAL_DEVICE_TYPE_DIRECT_ACCESS) { + CU_PASS("[SKIPPED] LUN is not SBC device. Skipping test"); + return; + } + + /* + * Try out different non-zero values for RDPROTECT. + * They should all fail. + */ + logging(LOG_VERBOSE, ""); + logging(LOG_VERBOSE, "Test READ16 with non-zero RDPROTECT"); + for (i = 1; i < 8; i++) { + ret = read16_invalidfieldincdb(iscsic, tgt_lun, 0, + block_size, block_size, + i, 0, 0, 0, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + } +} diff --git a/test-tool/test_read16_simple.c b/test-tool/test_read16_simple.c new file mode 100644 index 0000000..c3fb9a6 --- /dev/null +++ b/test-tool/test_read16_simple.c @@ -0,0 +1,50 @@ + +/* + Copyright (C) 2013 Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include + +#include + +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-support.h" +#include "iscsi-test-cu.h" + + +void +test_read16_simple(void) +{ + int i, ret; + + + logging(LOG_VERBOSE, ""); + logging(LOG_VERBOSE, "Test READ16 of 1-256 blocks at the start of the LUN"); + for (i = 1; i <= 256; i++) { + ret = read16(iscsic, tgt_lun, 0, i * block_size, + block_size, 0, 0, 0, 0, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + } + + + logging(LOG_VERBOSE, "Test READ16 of 1-256 blocks at the end of the LUN"); + for (i = 1; i <= 256; i++) { + ret = read16(iscsic, tgt_lun, num_blocks +1 - i, + i * block_size, block_size, 0, 0, 0, 0, 0, NULL); + CU_ASSERT_EQUAL(ret, 0); + } +}