From 0f886b7d3a80678e7401d808a680fb9551e4a10d Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Sat, 20 Feb 2016 14:36:32 -0800 Subject: [PATCH] TaskMgmt: Remove null pointer check We do not need to check the pointer for null here since it is guaranteed to never be. Signed-off-by: Ronnie Sahlberg --- lib/sync.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/sync.c b/lib/sync.c index 2307bae..6f18a42 100644 --- a/lib/sync.c +++ b/lib/sync.c @@ -221,10 +221,8 @@ iscsi_task_mgmt_sync_cb(struct iscsi_context *iscsi, int status, { struct iscsi_sync_state *state = private_data; - if (state != NULL) { - state->status = status; - state->finished = 1; - } + state->status = status; + state->finished = 1; /* The task mgmt command might have completed successfully * but the target might have responded with @@ -248,7 +246,7 @@ iscsi_task_mgmt_sync_cb(struct iscsi_context *iscsi, int status, break; } - state->status = SCSI_STATUS_ERROR; + state->status = SCSI_STATUS_ERROR; } }