admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

T1030_unsolicited_data_overflow: remove unused variable

Browse Source 
old_first_burst_len is set but never used - remove it. Also replace an
  if (!ptr)
    free(ptr)
with
  free(ptr)

as the check is redundant.

Signed-off-by: Arne Redlich <arne.redlich@googlemail.com>
This commit is contained in:
Arne Redlich
2012-10-31 16:48:48 +01:00
parent e0555555bb
commit 17e8b54759
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test-tool/1030_unsolicited_data_overflow.c
View File

@@ -47,7 +47,6 @@ int T1030_unsolicited_data_overflow(const char *initiator, const char *url, int
int ret, lun; int ret, lun;
unsigned char *buf = NULL; unsigned char *buf = NULL;
struct iscsi_async_state test_state; struct iscsi_async_state test_state;
uint32_t old_first_burst_len;
printf("1030_unsolicited_data_overflow:\n"); printf("1030_unsolicited_data_overflow:\n");
printf("===============================\n"); printf("===============================\n");
@@ -99,7 +98,7 @@ int T1030_unsolicited_data_overflow(const char *initiator, const char *url, int
ret = 0; ret = 0;
iscsi->use_immediate_data = ISCSI_IMMEDIATE_DATA_YES; iscsi->use_immediate_data = ISCSI_IMMEDIATE_DATA_YES;
old_first_burst_len = iscsi->first_burst_length;
/* make first burst REAL big */ /* make first burst REAL big */
iscsi->first_burst_length *= 16; iscsi->first_burst_length *= 16;
buf = malloc(iscsi->first_burst_length); buf = malloc(iscsi->first_burst_length);
@@ -141,9 +140,8 @@ test2:
printf("[OK]\n"); printf("[OK]\n");
finished: finished:
if (buf) {
free(buf); free(buf);
}
iscsi_destroy_context(iscsi); iscsi_destroy_context(iscsi);
iscsi_destroy_context(iscsi2); iscsi_destroy_context(iscsi2);
return ret; return ret;