admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

test_report_supported_opcodes_rctd: Fix a NULL pointer dereference

Browse Source 
Avoid that the test tool crashes due to a NULL pointer dereference
if unmarshalling the Data-In buffer fails.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
This commit is contained in:
Bart Van Assche
2017-05-17 17:09:23 -07:00
parent 12222077cc
commit 1971294017
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
test-tool/test_report_supported_opcodes_rctd.c
View File

@@ -70,6 +70,8 @@ test_report_supported_opcodes_rctd(void)
logging(LOG_VERBOSE, "Unmarshall the DATA-IN buffer"); logging(LOG_VERBOSE, "Unmarshall the DATA-IN buffer");
rsoc = scsi_datain_unmarshall(rso_task); rsoc = scsi_datain_unmarshall(rso_task);
CU_ASSERT_NOT_EQUAL(rsoc, NULL); CU_ASSERT_NOT_EQUAL(rsoc, NULL);
if (!rsoc)
goto free_task;
logging(LOG_VERBOSE, "Verify that all returned command descriptors " logging(LOG_VERBOSE, "Verify that all returned command descriptors "
"have a timeout description"); "have a timeout description");
@@ -94,5 +96,6 @@ test_report_supported_opcodes_rctd(void)
} }
} }
free_task:
scsi_free_scsi_task(rso_task); scsi_free_scsi_task(rso_task);
} }