From 1f91358c8a86d5b170f6de879744c519f198f11d Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Tue, 25 Mar 2025 16:27:50 +1000 Subject: [PATCH] Flag variables in iscsi_context for multithreading audit These variables may need to be protected by a mutex. Signed-off-by: Ronnie Sahlberg --- include/iscsi-private.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/include/iscsi-private.h b/include/iscsi-private.h index 1cd0b5b..ec1b85e 100644 --- a/include/iscsi-private.h +++ b/include/iscsi-private.h @@ -131,12 +131,12 @@ struct iscsi_context { enum iscsi_session_type session_type; unsigned char isid[6]; uint8_t rdma_ack_timeout; - uint32_t itt; - uint32_t cmdsn; - uint32_t min_cmdsn_waiting; - uint32_t expcmdsn; - uint32_t maxcmdsn; - uint32_t statsn; + uint32_t itt; // multithreading todo: may need mutex + uint32_t cmdsn; // multithreading todo: may need mutex + uint32_t min_cmdsn_waiting; // multithreading todo: may need mutex + uint32_t expcmdsn; // multithreading todo: may need mutex + uint32_t maxcmdsn; // multithreading todo: may need mutex + uint32_t statsn; // multithreading todo: may need mutex enum iscsi_header_digest want_header_digest; enum iscsi_header_digest header_digest; enum iscsi_data_digest want_data_digest; @@ -170,11 +170,11 @@ struct iscsi_context { iscsi_command_cb socket_status_cb; void *connect_data; - struct iscsi_pdu *outqueue; - struct iscsi_pdu *outqueue_current; - struct iscsi_pdu *waitpdu; + struct iscsi_pdu *outqueue; // multithreading todo: may need mutex + struct iscsi_pdu *outqueue_current; // multithreading todo: may need mutex + struct iscsi_pdu *waitpdu; // multithreading todo: may need mutex - struct iscsi_in_pdu *incoming; + struct iscsi_in_pdu *incoming; // multithreading todo: may need mutex uint32_t max_burst_length; uint32_t first_burst_length;