admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Returned buffers from poptGetArgs() are free()ed in poptFreeContext()

Browse Source 
Calling "free(url);" causes a core dump in glibc-2.15.

Signed-off-by: Bernhard Kohl <bernhard.kohl@gmx.net>
This commit is contained in:
Bernhard Kohl
2012-11-18 22:51:57 +01:00
committed by Ronnie Sahlberg
parent a75727d989
commit 219533dc7b
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/iscsi-inq.c
View File

@@ -243,7 +243,7 @@ int main(int argc, const char *argv[])
} }
extra_argv = poptGetArgs(pc); extra_argv = poptGetArgs(pc);
if (extra_argv) { if (extra_argv) {
url = *extra_argv; url = strdup(*extra_argv);
extra_argv++; extra_argv++;
while (extra_argv[extra_argc]) { while (extra_argv[extra_argc]) {
extra_argc++; extra_argc++;

2
src/iscsi-ls.c
View File

@@ -340,7 +340,7 @@ int main(int argc, const char *argv[])
} }
extra_argv = poptGetArgs(pc); extra_argv = poptGetArgs(pc);
if (extra_argv) { if (extra_argv) {
url = *extra_argv; url = strdup(*extra_argv);
extra_argv++; extra_argv++;
while (extra_argv[extra_argc]) { while (extra_argv[extra_argc]) {
extra_argc++; extra_argc++;

2
src/iscsi-readcapacity16.c
View File

@@ -86,7 +86,7 @@ int main(int argc, const char *argv[])
} }
extra_argv = poptGetArgs(pc); extra_argv = poptGetArgs(pc);
if (extra_argv) { if (extra_argv) {
url = *extra_argv; url = strdup(*extra_argv);
extra_argv++; extra_argv++;
while (extra_argv[extra_argc]) { while (extra_argv[extra_argc]) {
extra_argc++; extra_argc++;

2
test-tool/iscsi-test.c
View File

@@ -410,7 +410,7 @@ int main(int argc, const char *argv[])
} }
extra_argv = poptGetArgs(pc); extra_argv = poptGetArgs(pc);
if (extra_argv) { if (extra_argv) {
url = *extra_argv; url = strdup(*extra_argv);
extra_argv++; extra_argv++;
while (extra_argv[extra_argc]) { while (extra_argv[extra_argc]) {
extra_argc++; extra_argc++;