From 2838e6f6acec4a8ee5b773c90242720a969f45fb Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Fri, 22 Apr 2011 11:41:33 +1000 Subject: [PATCH] Add tests for reading beyong eol for READ6 --- test-tool/0121_read6_beyond_eol.c | 182 ++++++++++++++++++++++++++++++ test-tool/Makefile | 2 +- test-tool/iscsi-test.c | 1 + test-tool/iscsi-test.h | 1 + 4 files changed, 185 insertions(+), 1 deletion(-) create mode 100644 test-tool/0121_read6_beyond_eol.c diff --git a/test-tool/0121_read6_beyond_eol.c b/test-tool/0121_read6_beyond_eol.c new file mode 100644 index 0000000..089b52d --- /dev/null +++ b/test-tool/0121_read6_beyond_eol.c @@ -0,0 +1,182 @@ +/* + Copyright (C) 2010 by Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-test.h" + +int T0121_read6_beyond_eol(const char *initiator, const char *url) +{ + struct iscsi_context *iscsi; + struct scsi_task *task; + struct scsi_readcapacity10 *rc10; + int ret, i, lun; + uint32_t block_size, num_blocks; + + iscsi = iscsi_context_login(initiator, url, &lun); + if (iscsi == NULL) { + printf("Failed to login to target\n"); + return -1; + } + + /* find the size of the LUN */ + task = iscsi_readcapacity10_sync(iscsi, lun, 0, 0); + if (task == NULL) { + printf("Failed to send readcapacity10 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto finished; + } + if (task->status != SCSI_STATUS_GOOD) { + printf("Readcapacity command: failed with sense. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + rc10 = scsi_datain_unmarshall(task); + if (rc10 == NULL) { + printf("failed to unmarshall readcapacity10 data. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + block_size = rc10->block_size; + num_blocks = rc10->lba; + scsi_free_scsi_task(task); + + ret = 0; + + if (num_blocks > 0x1fffff) { + printf("[SKIPPED]\n"); + printf("Lun is too big for read-beyond-eol tests with read6\n"); + goto finished; + } + + + /* read 1-256 blocks, one block beyond the end-of-lun */ + printf("Reading last 1-256 blocks one block beyond eol ... "); + for (i=1; i<=256; i++) { + task = iscsi_read6_sync(iscsi, lun, num_blocks + 2 - i, i * block_size, block_size); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send read6 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto test_2; + } + if (task->status == SCSI_STATUS_GOOD) { + printf("[FAILED]\n"); + printf("Read6 beyond end-of-lun did not fail with sense.\n"); + ret = -1; + scsi_free_scsi_task(task); + goto test_2; + } + if (task->sense.key != SCSI_SENSE_ILLEGAL_REQUEST) { + printf("[FAILED]\n"); + printf("Read6 beyond end-of-lun did not return sense key ILLEGAL_REQUEST.\n"); + ret = -1; + scsi_free_scsi_task(task); + goto test_2; + } + if (task->sense.ascq != SCSI_SENSE_ASCQ_LBA_OUT_OF_RANGE) { + printf("[FAILED]\n"); + printf("Read6 beyond end-of-lun did not return sense ascq LBA OUT OF RANGE.\n"); + ret = -1; + scsi_free_scsi_task(task); + goto test_2; + } + scsi_free_scsi_task(task); + } + printf("[OK]\n"); + + +test_2: + /* read 2-256 blocks, all but one block beyond the eol */ + printf("Reading 1-255 blocks beyond eol starting at last block ... "); + for (i=2; i<=256; i++) { + task = iscsi_read6_sync(iscsi, lun, num_blocks, i * block_size, block_size); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send read6 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto test_3; + } + if (task->status == SCSI_STATUS_GOOD) { + printf("[FAILED]\n"); + printf("Read6 beyond end-of-lun did not return sense.\n"); + ret = -1; + scsi_free_scsi_task(task); + goto test_3; + } + if (task->sense.key != SCSI_SENSE_ILLEGAL_REQUEST) { + printf("[FAILED]\n"); + printf("Read6 beyond end-of-lun did not return sense key ILLEGAL_REQUEST.\n"); + ret = -1; + scsi_free_scsi_task(task); + goto test_3; + } + if (task->sense.ascq != SCSI_SENSE_ASCQ_LBA_OUT_OF_RANGE) { + printf("[FAILED]\n"); + printf("Read6 beyond end-of-lun did not return sense ascq LBA OUT OF RANGE.\n"); + ret = -1; + scsi_free_scsi_task(task); + goto test_3; + } + scsi_free_scsi_task(task); + } + printf("[OK]\n"); + + +test_3: + /* read 0 (==256) blocks 128 blocks from eol */ + printf("Reading 0(==256) blocks beyond eol starting at 128 blocks before eol ... "); + task = iscsi_read6_sync(iscsi, lun, num_blocks-128, i * block_size, block_size); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send read6 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto finished; + } + if (task->status == SCSI_STATUS_GOOD) { + printf("[FAILED]\n"); + printf("Read6 beyond end-of-lun did not return sense.\n"); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + if (task->sense.key != SCSI_SENSE_ILLEGAL_REQUEST) { + printf("[FAILED]\n"); + printf("Read6 beyond end-of-lun did not return sense key ILLEGAL_REQUEST.\n"); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + if (task->sense.ascq != SCSI_SENSE_ASCQ_LBA_OUT_OF_RANGE) { + printf("[FAILED]\n"); + printf("Read6 beyond end-of-lun did not return sense ascq LBA OUT OF RANGE.\n"); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + scsi_free_scsi_task(task); + printf("[OK]\n"); + + +finished: + iscsi_logout_sync(iscsi); + iscsi_destroy_context(iscsi); + return ret; +} diff --git a/test-tool/Makefile b/test-tool/Makefile index f4de5da..49ef2dd 100644 --- a/test-tool/Makefile +++ b/test-tool/Makefile @@ -4,7 +4,7 @@ CFLAGS=-g -O0 -fPIC -Wall -W -I. -I./include -I../include "-D_U_=__attribute__(( TESTS=0100_read10_simple.o 0101_read10_beyond_eol.o 0102_read10_0blocks.o \ 0103_read10_rdprotect.o 0104_read10_flags.o 0105_read10_invalid.o \ 0110_readcapacity10_simple.o 0111_readcapacity10_pmi.o \ -0120_read6_simple.o +0120_read6_simple.o 0121_read6_beyond_eol.o all: iscsi-test diff --git a/test-tool/iscsi-test.c b/test-tool/iscsi-test.c index 94540a0..4ae4d58 100644 --- a/test-tool/iscsi-test.c +++ b/test-tool/iscsi-test.c @@ -50,6 +50,7 @@ struct scsi_test tests[] = { /* read6*/ { "T0120_read6_simple", T0120_read6_simple }, +{ "T0121_read6_beyond_eol", T0121_read6_beyond_eol }, { NULL, NULL } }; diff --git a/test-tool/iscsi-test.h b/test-tool/iscsi-test.h index 7253437..b38ca97 100644 --- a/test-tool/iscsi-test.h +++ b/test-tool/iscsi-test.h @@ -31,3 +31,4 @@ int T0110_readcapacity10_simple(const char *initiator, const char *url); int T0111_readcapacity10_pmi(const char *initiator, const char *url); int T0120_read6_simple(const char *initiator, const char *url); +int T0121_read6_beyond_eol(const char *initiator, const char *url);