From 2873b18bb79be5f98a2e1ec027f1e850b22d39c9 Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Mon, 25 Mar 2013 17:42:24 -0700 Subject: [PATCH] TESTS: Add tests to verify that RELEASE6 is dropped on target/lun reset --- Makefile.am | 3 + test-tool/iscsi-test-cu.c | 3 + test-tool/iscsi-test-cu.h | 3 + test-tool/test_reserve6_itnexus_loss.c | 1 + test-tool/test_reserve6_lun_reset.c | 79 +++++++++++++++++++++ test-tool/test_reserve6_target_cold_reset.c | 78 ++++++++++++++++++++ test-tool/test_reserve6_target_warm_reset.c | 79 +++++++++++++++++++++ 7 files changed, 246 insertions(+) create mode 100644 test-tool/test_reserve6_lun_reset.c create mode 100644 test-tool/test_reserve6_target_cold_reset.c create mode 100644 test-tool/test_reserve6_target_warm_reset.c diff --git a/Makefile.am b/Makefile.am index fa50c38..5bc3786 100644 --- a/Makefile.am +++ b/Makefile.am @@ -252,6 +252,9 @@ bin_iscsi_test_cu_SOURCES = test-tool/iscsi-test-cu.c \ test-tool/test_reserve6_2initiators.c \ test-tool/test_reserve6_logout.c \ test-tool/test_reserve6_itnexus_loss.c \ + test-tool/test_reserve6_target_warm_reset.c \ + test-tool/test_reserve6_target_cold_reset.c \ + test-tool/test_reserve6_lun_reset.c \ test-tool/test_startstopunit_simple.c \ test-tool/test_startstopunit_pwrcnd.c \ test-tool/test_startstopunit_noloej.c \ diff --git a/test-tool/iscsi-test-cu.c b/test-tool/iscsi-test-cu.c index 42ce450..8871010 100644 --- a/test-tool/iscsi-test-cu.c +++ b/test-tool/iscsi-test-cu.c @@ -222,6 +222,9 @@ static CU_TestInfo tests_reserve6[] = { { (char *)"testReserve6_2Initiators", test_reserve6_2initiators }, { (char *)"testReserve6Logout", test_reserve6_logout }, { (char *)"testReserve6ITNexusLoss", test_reserve6_itnexus_loss }, + { (char *)"testReserve6TargetColdReset", test_reserve6_target_cold_reset }, + { (char *)"testReserve6TargetWarmReset", test_reserve6_target_warm_reset }, + { (char *)"testReserve6LUNReset", test_reserve6_lun_reset }, CU_TEST_INFO_NULL }; diff --git a/test-tool/iscsi-test-cu.h b/test-tool/iscsi-test-cu.h index 75cea1d..1d2dcc4 100644 --- a/test-tool/iscsi-test-cu.h +++ b/test-tool/iscsi-test-cu.h @@ -134,6 +134,9 @@ void test_reserve6_simple(void); void test_reserve6_2initiators(void); void test_reserve6_logout(void); void test_reserve6_itnexus_loss(void); +void test_reserve6_target_cold_reset(void); +void test_reserve6_target_warm_reset(void); +void test_reserve6_lun_reset(void); void test_startstopunit_simple(void); void test_startstopunit_pwrcnd(void); diff --git a/test-tool/test_reserve6_itnexus_loss.c b/test-tool/test_reserve6_itnexus_loss.c index 8d3fa45..2c8e10b 100644 --- a/test-tool/test_reserve6_itnexus_loss.c +++ b/test-tool/test_reserve6_itnexus_loss.c @@ -59,6 +59,7 @@ test_reserve6_itnexus_loss(void) logging(LOG_VERBOSE, "Disconnect from the target."); iscsi_destroy_context(iscsic); + logging(LOG_VERBOSE, "Sleep for three seconds incase the target is slow to reset"); sleep(3); logging(LOG_VERBOSE, "Reconnect to target"); diff --git a/test-tool/test_reserve6_lun_reset.c b/test-tool/test_reserve6_lun_reset.c new file mode 100644 index 0000000..7e70ec7 --- /dev/null +++ b/test-tool/test_reserve6_lun_reset.c @@ -0,0 +1,79 @@ +/* + Copyright (C) 2013 Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include + +#include + +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-support.h" +#include "iscsi-test-cu.h" + + +void +test_reserve6_lun_reset(void) +{ + int ret; + + + logging(LOG_VERBOSE, LOG_BLANK_LINE); + logging(LOG_VERBOSE, "Test that RESERVE6 is released on lun reset"); + + + logging(LOG_VERBOSE, "Take out a RESERVE6 from the first initiator"); + ret = reserve6(iscsic, tgt_lun); + if (ret == -2) { + logging(LOG_VERBOSE, "[SKIPPED] Target does not support RESERVE6. Skipping test"); + CU_PASS("[SKIPPED] Target does not support RESERVE6. Skipping test"); + return; + } + CU_ASSERT_EQUAL(ret, 0); + + + logging(LOG_VERBOSE, "Create a second connection to the target"); + iscsic2 = iscsi_context_login(initiatorname1, tgt_url, &tgt_lun); + if (iscsic2 == NULL) { + logging(LOG_VERBOSE, "Failed to login to target"); + return; + } + + logging(LOG_VERBOSE, "Try to take out a RESERVE6 from the second initiator"); + ret = reserve6_conflict(iscsic2, tgt_lun); + CU_ASSERT_EQUAL(ret, 0); + + + + logging(LOG_VERBOSE, "Send a LUN Reset"); + ret = iscsi_task_mgmt_lun_reset_sync(iscsic, tgt_lun); + if (ret != 0) { + logging(LOG_NORMAL, "LUN reset failed"); + } + CU_ASSERT_EQUAL(ret, 0); + + logging(LOG_VERBOSE, "Sleep for three seconds incase the target is slow to reset"); + sleep(3); + + + logging(LOG_VERBOSE, "RESERVE6 from the second initiator should work now"); + ret = reserve6(iscsic2, tgt_lun); + CU_ASSERT_EQUAL(ret, 0); + + logging(LOG_VERBOSE, "RELEASE6 from the second initiator"); + ret = release6(iscsic2, tgt_lun); + CU_ASSERT_EQUAL(ret, 0); +} diff --git a/test-tool/test_reserve6_target_cold_reset.c b/test-tool/test_reserve6_target_cold_reset.c new file mode 100644 index 0000000..3402b61 --- /dev/null +++ b/test-tool/test_reserve6_target_cold_reset.c @@ -0,0 +1,78 @@ +/* + Copyright (C) 2013 Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include + +#include + +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-support.h" +#include "iscsi-test-cu.h" + + +void +test_reserve6_target_cold_reset(void) +{ + int ret; + + + logging(LOG_VERBOSE, LOG_BLANK_LINE); + logging(LOG_VERBOSE, "Test that RESERVE6 is released on target cold reset"); + + + logging(LOG_VERBOSE, "Take out a RESERVE6 from the first initiator"); + ret = reserve6(iscsic, tgt_lun); + if (ret == -2) { + logging(LOG_VERBOSE, "[SKIPPED] Target does not support RESERVE6. Skipping test"); + CU_PASS("[SKIPPED] Target does not support RESERVE6. Skipping test"); + return; + } + CU_ASSERT_EQUAL(ret, 0); + + + logging(LOG_VERBOSE, "Create a second connection to the target"); + iscsic2 = iscsi_context_login(initiatorname1, tgt_url, &tgt_lun); + if (iscsic2 == NULL) { + logging(LOG_VERBOSE, "Failed to login to target"); + return; + } + + logging(LOG_VERBOSE, "Try to take out a RESERVE6 from the second initiator"); + ret = reserve6_conflict(iscsic2, tgt_lun); + CU_ASSERT_EQUAL(ret, 0); + + + + logging(LOG_VERBOSE, "Send a Cold Reset to the target"); + ret = iscsi_task_mgmt_target_cold_reset_sync(iscsic); + if (ret != 0) { + logging(LOG_NORMAL, "Cold reset failed"); + } + CU_ASSERT_EQUAL(ret, 0); + + logging(LOG_VERBOSE, "Sleep for three seconds incase the target is slow to reset"); + sleep(3); + + logging(LOG_VERBOSE, "RESERVE6 from the second initiator should work now"); + ret = reserve6(iscsic2, tgt_lun); + CU_ASSERT_EQUAL(ret, 0); + + logging(LOG_VERBOSE, "RELEASE6 from the second initiator"); + ret = release6(iscsic2, tgt_lun); + CU_ASSERT_EQUAL(ret, 0); +} diff --git a/test-tool/test_reserve6_target_warm_reset.c b/test-tool/test_reserve6_target_warm_reset.c new file mode 100644 index 0000000..e24b3b3 --- /dev/null +++ b/test-tool/test_reserve6_target_warm_reset.c @@ -0,0 +1,79 @@ +/* + Copyright (C) 2013 Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include + +#include + +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-support.h" +#include "iscsi-test-cu.h" + + +void +test_reserve6_target_warm_reset(void) +{ + int ret; + + + logging(LOG_VERBOSE, LOG_BLANK_LINE); + logging(LOG_VERBOSE, "Test that RESERVE6 is released on target warm reset"); + + + logging(LOG_VERBOSE, "Take out a RESERVE6 from the first initiator"); + ret = reserve6(iscsic, tgt_lun); + if (ret == -2) { + logging(LOG_VERBOSE, "[SKIPPED] Target does not support RESERVE6. Skipping test"); + CU_PASS("[SKIPPED] Target does not support RESERVE6. Skipping test"); + return; + } + CU_ASSERT_EQUAL(ret, 0); + + + logging(LOG_VERBOSE, "Create a second connection to the target"); + iscsic2 = iscsi_context_login(initiatorname1, tgt_url, &tgt_lun); + if (iscsic2 == NULL) { + logging(LOG_VERBOSE, "Failed to login to target"); + return; + } + + logging(LOG_VERBOSE, "Try to take out a RESERVE6 from the second initiator"); + ret = reserve6_conflict(iscsic2, tgt_lun); + CU_ASSERT_EQUAL(ret, 0); + + + + logging(LOG_VERBOSE, "Send a Warm Reset to the target"); + ret = iscsi_task_mgmt_target_warm_reset_sync(iscsic); + if (ret != 0) { + logging(LOG_NORMAL, "Warm reset failed"); + } + CU_ASSERT_EQUAL(ret, 0); + + logging(LOG_VERBOSE, "Sleep for three seconds incase the target is slow to reset"); + sleep(3); + + + logging(LOG_VERBOSE, "RESERVE6 from the second initiator should work now"); + ret = reserve6(iscsic2, tgt_lun); + CU_ASSERT_EQUAL(ret, 0); + + logging(LOG_VERBOSE, "RELEASE6 from the second initiator"); + ret = release6(iscsic2, tgt_lun); + CU_ASSERT_EQUAL(ret, 0); +}